Re: [PATCH 3/3 net-next] test_objagg: Uninitialized variable in error handling

2019-02-13 Thread David Miller
From: Dan Carpenter Date: Wed, 13 Feb 2019 11:59:31 +0300 > We need to set the error message on this path otherwise some of the > callers, such as test_hints_case(), print from an uninitialized pointer. > > We had a similar bug earlier and set "errmsg" to NULL in the caller, > test_delta_action_

Re: [PATCH 3/3 net-next] test_objagg: Uninitialized variable in error handling

2019-02-13 Thread Jiri Pirko
Wed, Feb 13, 2019 at 09:59:31AM CET, dan.carpen...@oracle.com wrote: >We need to set the error message on this path otherwise some of the >callers, such as test_hints_case(), print from an uninitialized pointer. > >We had a similar bug earlier and set "errmsg" to NULL in the caller, >test_delta_act

[PATCH 3/3 net-next] test_objagg: Uninitialized variable in error handling

2019-02-13 Thread Dan Carpenter
We need to set the error message on this path otherwise some of the callers, such as test_hints_case(), print from an uninitialized pointer. We had a similar bug earlier and set "errmsg" to NULL in the caller, test_delta_action_item(). That code is no longer required so I have removed it. Fixes: