Re: [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses

2017-05-22 Thread Andy Shevchenko
On Mon, May 22, 2017 at 2:12 PM, Jan Kiszka wrote: > Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr. > struct stmmac_pci_dmi_data { > - const char *name; > - const char *asset_tag; > - unsigned int func; > + int func; > int phy_addr; > }; Pe

Re: [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses

2017-05-22 Thread Joe Perches
On Mon, 2017-05-22 at 14:49 +0200, Jan Kiszka wrote: > On 2017-05-22 13:33, Joe Perches wrote: > > On Mon, 2017-05-22 at 13:12 +0200, Jan Kiszka wrote: > > > Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr. > > > > [] > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmma

Re: [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses

2017-05-22 Thread Jan Kiszka
On 2017-05-22 13:33, Joe Perches wrote: > On Mon, 2017-05-22 at 13:12 +0200, Jan Kiszka wrote: >> Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr. > [] >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c >> b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c > [] >>

Re: [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses

2017-05-22 Thread Joe Perches
On Mon, 2017-05-22 at 13:12 +0200, Jan Kiszka wrote: > Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr. [] > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c [] > @@ -31,65 +31,78 @@ [] > +static const struct stm

[PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses

2017-05-22 Thread Jan Kiszka
Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr. Signed-off-by: Jan Kiszka --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 77 ++-- 1 file changed, 45 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/d