Hi Kirtika,
On Mon, May 30, 2016 at 10:44 AM, Kirtika Ruchandani
wrote:
>>> There's too much stuff here to quickly review, it'd be nice if you
>>> could split this up into patches that do the following:
>
> Is it preferable to resend the whole patch-set or just patch 3/3 in
> this one as a separa
>> There's too much stuff here to quickly review, it'd be nice if you
>> could split this up into patches that do the following:
Is it preferable to resend the whole patch-set or just patch 3/3 in
this one as a separate set?
> There's too much stuff here to quickly review, it'd be nice if you
> could split this up into patches that do the following:
Thanks, I will send out a v2 with the split you suggested.
Hi Kirtika,
On Sun, May 29, 2016 at 1:31 PM, Kirtika Ruchandani
wrote:
> This patch fixes the following checkpatch.pl issues -
There's too much stuff here to quickly review, it'd be nice if you
could split this up into patches that do the following:
Space issues:
> - space preferred around that
This patch fixes the following checkpatch.pl issues -
- space preferred around that
- no space needed after cast.
- braces {} should be used on all arms of this statement
- Alignment should match open parenthesis
- suspect code indent for conditional statements
- Statements should start on a tabst
