Re: [PATCH 3/3] net: mvpp2: Return correct error codes

2016-02-13 Thread David Miller
From: Amitoj Kaur Chawla Date: Thu, 4 Feb 2016 19:25:26 +0530 > The return value of kzalloc on failure of allocation of memory should > be -ENOMEM and not -1. > > Found using Coccinelle. A simplified version of the semantic patch > used is: ... > This function may also return -1 after calling m

[PATCH 3/3] net: mvpp2: Return correct error codes

2016-02-04 Thread Amitoj Kaur Chawla
The return value of kzalloc on failure of allocation of memory should be -ENOMEM and not -1. Found using Coccinelle. A simplified version of the semantic patch used is: // @@ expression *e; position p,q; @@ e@q = kzalloc(...); if@p (e == NULL) { ... return - -1 + -ENOMEM ; } // This function ma