Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-07-11 Thread Dongpo Li
On 2016/7/11 16:16, Arnd Bergmann wrote: > On Monday, July 11, 2016 11:44:23 AM CEST Dongpo Li wrote: >> Hi Arnd, >> >> On 2016/6/28 17:34, Arnd Bergmann wrote: >>> On Tuesday, June 28, 2016 5:21:19 PM CEST Dongpo Li wrote: On 2016/6/15 5:20, Arnd Bergmann wrote: > On Tuesday, June 14, 2

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-07-11 Thread Arnd Bergmann
On Monday, July 11, 2016 11:44:23 AM CEST Dongpo Li wrote: > Hi Arnd, > > On 2016/6/28 17:34, Arnd Bergmann wrote: > > On Tuesday, June 28, 2016 5:21:19 PM CEST Dongpo Li wrote: > >> On 2016/6/15 5:20, Arnd Bergmann wrote: > >>> On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: > On

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-07-10 Thread Dongpo Li
Hi Arnd, On 2016/6/28 17:34, Arnd Bergmann wrote: > On Tuesday, June 28, 2016 5:21:19 PM CEST Dongpo Li wrote: >> On 2016/6/15 5:20, Arnd Bergmann wrote: >>> On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: On 2016/6/13 17:06, Arnd Bergmann wrote: > On Monday, June 13, 2016 2:07

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-28 Thread Arnd Bergmann
On Tuesday, June 28, 2016 5:21:19 PM CEST Dongpo Li wrote: > On 2016/6/15 5:20, Arnd Bergmann wrote: > > On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: > >> On 2016/6/13 17:06, Arnd Bergmann wrote: > >>> On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: > >>> You tx function use

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-28 Thread Dongpo Li
On 2016/6/15 5:20, Arnd Bergmann wrote: > On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: >> On 2016/6/13 17:06, Arnd Bergmann wrote: >>> On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: >>> You tx function uses BQL to optimize the queue length, and that >>> is great. You also

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-15 Thread Dongpo Li
On 2016/6/15 6:31, Rob Herring wrote: > On Mon, Jun 13, 2016 at 02:07:56PM +0800, Dongpo Li wrote: >> This patch adds the Hisilicon Fast Ethernet MAC(FEMAC) driver. >> The FEMAC supports max speed 100Mbps and has been used in many >> Hisilicon SoC. >> >> Reviewed-by: Jiancheng Xue >> Signed-off-

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-15 Thread Dongpo Li
On 2016/6/15 5:20, Arnd Bergmann wrote: > On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: >> On 2016/6/13 17:06, Arnd Bergmann wrote: >>> On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: >>> You tx function uses BQL to optimize the queue length, and that >>> is great. You also

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-14 Thread Rob Herring
On Mon, Jun 13, 2016 at 02:07:56PM +0800, Dongpo Li wrote: > This patch adds the Hisilicon Fast Ethernet MAC(FEMAC) driver. > The FEMAC supports max speed 100Mbps and has been used in many > Hisilicon SoC. > > Reviewed-by: Jiancheng Xue > Signed-off-by: Dongpo Li > --- > .../devicetree/bindings

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-14 Thread Arnd Bergmann
On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: > On 2016/6/13 17:06, Arnd Bergmann wrote: > > On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: > > You tx function uses BQL to optimize the queue length, and that > > is great. You also check xmit reclaim for rx interrupts, so > >

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-14 Thread Li Dongpo
On 2016/6/13 17:06, Arnd Bergmann wrote: > On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: > >> +- reset-names: should contain the reset signal name "mac_reset"(required) >> +and "phy_reset"(optional). > > Maybe just name the resets 'mac' and 'phy'? The '_reset' part is > implied

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-13 Thread Arnd Bergmann
On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: > +- reset-names: should contain the reset signal name "mac_reset"(required) > + and "phy_reset"(optional). Maybe just name the resets 'mac' and 'phy'? The '_reset' part is implied by the property. I gave the driver a brief review and

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-13 Thread kbuild test robot
Hi, [auto build test WARNING on net/master] [also build test WARNING on v4.7-rc3 next-20160609] [cannot apply to net-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dongpo-Li/Add-His

[PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-12 Thread Dongpo Li
This patch adds the Hisilicon Fast Ethernet MAC(FEMAC) driver. The FEMAC supports max speed 100Mbps and has been used in many Hisilicon SoC. Reviewed-by: Jiancheng Xue Signed-off-by: Dongpo Li --- .../devicetree/bindings/net/hisilicon-femac.txt| 40 + drivers/net/ethernet/hisilicon/Kconfi