Re: [PATCH 3/3] net: ethernet: bgmac: driver power manangement

2017-02-06 Thread Jon Mason
On Fri, Feb 3, 2017 at 9:16 PM, Florian Fainelli wrote: > On 02/03/2017 01:39 PM, Jon Mason wrote: >> From: Joey Zhong >> >> Implements suspend/resume, external phy 54810 is assumed >> to remain powered up during deep-sleep for wake-on-lane. > > s/wake-on-lane/Wake-on-LAN, are you positive phy_st

Re: [PATCH 3/3] net: ethernet: bgmac: driver power manangement

2017-02-03 Thread Florian Fainelli
On 02/03/2017 01:39 PM, Jon Mason wrote: > From: Joey Zhong > > Implements suspend/resume, external phy 54810 is assumed > to remain powered up during deep-sleep for wake-on-lane. s/wake-on-lane/Wake-on-LAN, are you positive phy_stop() is not suspending the PHY and issuing BMCR_PWRDOWN write? T

[PATCH 3/3] net: ethernet: bgmac: driver power manangement

2017-02-03 Thread Jon Mason
From: Joey Zhong Implements suspend/resume, external phy 54810 is assumed to remain powered up during deep-sleep for wake-on-lane. Signed-off-by: Joey Zhong Signed-off-by: Jon Mason --- drivers/net/ethernet/broadcom/bgmac-platform.c | 34 + drivers/net/ethernet/broadcom/bgmac.