Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

2019-03-04 Thread Vladimir Oltean
On Mon, 4 Mar 2019 at 15:53, Andrew Lunn wrote: > > > I do see that neither vitesse-vsc73xx nor rtl8366 do implement the bridge > > membership callbacks, and as I don't happen to know nearly enough about > > DSA, I > > wonder at what moment in time does forwarding get activated between ports. > >

Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

2019-03-04 Thread Andrew Lunn
> I do see that neither vitesse-vsc73xx nor rtl8366 do implement the bridge > membership callbacks, and as I don't happen to know nearly enough about DSA, I > wonder at what moment in time does forwarding get activated between ports. If those callbacks are not implement, it means the software brid

Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

2019-03-04 Thread Linus Walleij
Hi Vladimir, On Mon, Mar 4, 2019 at 1:14 PM Vladimir Oltean wrote: > I may be in error, but I don't think we have the same understanding of what > VLAN filtering is. As far as I understand, no VLAN filtering means that > hardware is required to not parse, push or pop VLAN tags in whatever frames

Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

2019-03-04 Thread Vladimir Oltean
On Mon, 4 Mar 2019 at 11:52, Linus Walleij wrote: > > Hi Vladimir, Hi Linus, > > On Sun, Mar 3, 2019 at 1:08 PM Vladimir Oltean wrote: > > > I am writing a DSA driver for a switch that doesn't support port separation > > through switch tagging, and came across this discussion. > > Would you min

Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

2019-03-04 Thread Linus Walleij
Hi Vladimir, On Sun, Mar 3, 2019 at 1:08 PM Vladimir Oltean wrote: > I am writing a DSA driver for a switch that doesn't support port separation > through switch tagging, and came across this discussion. > Would you mind to share some thoughts on how port separation with > DSA_TAG_PROTO_NONE wou

Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

2019-03-03 Thread Vladimir Oltean
On Sat, 30 Jun 2018 13:05:47, Linus Walleij wrote: > On Thu, Jun 14, 2018 at 6:51 PM Florian Fainelli wrote: > > On 06/14/2018 05:35 AM, Linus Walleij wrote: > > > > using DSA as a best fit so we can easily add VLAN support and maybe > > > later also exploit the internal frame header to get more d