Re: [PATCH 3/3] make sock_alloc_file() do sock_release() on failures

2017-12-05 Thread David Miller
From: Al Viro Date: Tue, 5 Dec 2017 23:29:09 + > This changes calling conventions (and simplifies the hell out > the callers). New rules: once struct socket had been passed > to sock_alloc_file(), it's been consumed either by struct file > or by sock_release() done by sock_alloc_file(). Eit

[PATCH 3/3] make sock_alloc_file() do sock_release() on failures

2017-12-05 Thread Al Viro
This changes calling conventions (and simplifies the hell out the callers). New rules: once struct socket had been passed to sock_alloc_file(), it's been consumed either by struct file or by sock_release() done by sock_alloc_file(). Either way the caller should not do sock_release() after that po

Re: [PATCH 3/3] make sock_alloc_file() do sock_release() on failures

2017-12-01 Thread Eric Dumazet
On Fri, 2017-12-01 at 00:23 +, Al Viro wrote: > This changes calling conventions (and simplifies the hell out > the callers).  New rules: once struct socket had been passed > to sock_alloc_file(), it's been consumed either by struct file > or by sock_release() done by sock_alloc_file().  Either

[PATCH 3/3] make sock_alloc_file() do sock_release() on failures

2017-11-30 Thread Al Viro
This changes calling conventions (and simplifies the hell out the callers). New rules: once struct socket had been passed to sock_alloc_file(), it's been consumed either by struct file or by sock_release() done by sock_alloc_file(). Either way the caller should not do sock_release() after that po