Re: [PATCH 3/3] gianfar: remove faulty filer optimizer

2015-08-11 Thread David Miller
S. Miller; Manoil Claudiu-B08782 >> >Cc: netdev@vger.kernel.org; Jakub Kicinski >> >Subject: [PATCH 3/3] gianfar: remove faulty filer optimizer >> > >> >From: Jakub Kicinski >> > >> >Current filer rule optimization is broken in several ways:

Re: [PATCH 3/3] gianfar: remove faulty filer optimizer

2015-08-11 Thread Jakub KiciƄski
icinski > >Subject: [PATCH 3/3] gianfar: remove faulty filer optimizer > > > >From: Jakub Kicinski > > > >Current filer rule optimization is broken in several ways: > > (1) It destroys rule ordering. > > (2) It performs reads/writes beyond end of allocat

RE: [PATCH 3/3] gianfar: remove faulty filer optimizer

2015-08-11 Thread Manoil Claudiu
>-Original Message- >From: Jakub Kicinski [mailto:moorr...@wp.pl] >Sent: Monday, August 10, 2015 11:12 PM >To: David S. Miller; Manoil Claudiu-B08782 >Cc: netdev@vger.kernel.org; Jakub Kicinski >Subject: [PATCH 3/3] gianfar: remove faulty filer optimizer > >From: Ja

[PATCH 3/3] gianfar: remove faulty filer optimizer

2015-08-10 Thread Jakub Kicinski
From: Jakub Kicinski Current filer rule optimization is broken in several ways: (1) It destroys rule ordering. (2) It performs reads/writes beyond end of allocated tables. (3) It breaks badly for rules with more than 2 specifiers (e.g. matching ip, port, tos). (4) We observed that the ma