Re: [PATCH 3/3] chelsio: more rx speedup

2007-01-18 Thread Jeff Garzik
Stephen Hemminger wrote: Cleanup receive processing some more: * do the reserve padding of skb during setup * don't pass constants to get_packet * do smart prefetch of skb * make copybreak a module parameter Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied - To unsubs

Re: [PATCH 3/3] chelsio: more rx speedup

2007-01-10 Thread Ingo Oeser
Divy Le Ray schrieb: > Stephen Hemminger wrote: > > On Tue, 9 Jan 2007 09:42:03 +0100 > > Ingo Oeser <[EMAIL PROTECTED]> wrote: > >> Stephen Hemminger schrieb: > >>> - if (fl->credits < drop_thres) { > >>> +use_orig_buf: > >>> + if (fl->credits < 2) { > >>> > >> Why 2? What does this magic n

Re: [PATCH 3/3] chelsio: more rx speedup

2007-01-10 Thread Ingo Oeser
Stephen Hemminger schrieb: > On Tue, 9 Jan 2007 09:42:03 +0100 > Ingo Oeser <[EMAIL PROTECTED]> wrote: > > Stephen Hemminger schrieb: > > > --- netdev-2.6.orig/drivers/net/chelsio/sge.c > > > +++ netdev-2.6/drivers/net/chelsio/sge.c > > Please use NET_IP_ALIGN here: > > Wrong, NET_IP_ALIGN is inte

Re: [PATCH 3/3] chelsio: more rx speedup

2007-01-09 Thread Divy Le Ray
Stephen Hemminger wrote: On Tue, 9 Jan 2007 09:42:03 +0100 Ingo Oeser <[EMAIL PROTECTED]> wrote: Hi Stephen, Stephen Hemminger schrieb: --- netdev-2.6.orig/drivers/net/chelsio/sge.c +++ netdev-2.6/drivers/net/chelsio/sge.c [...] @@ -1043,45 +1046,42 @@ static void recycl

Re: [PATCH 3/3] chelsio: more rx speedup

2007-01-09 Thread Stephen Hemminger
On Tue, 9 Jan 2007 09:42:03 +0100 Ingo Oeser <[EMAIL PROTECTED]> wrote: > Hi Stephen, > > Stephen Hemminger schrieb: > > --- netdev-2.6.orig/drivers/net/chelsio/sge.c > > +++ netdev-2.6/drivers/net/chelsio/sge.c > [...] > > @@ -1043,45 +1046,42 @@ static void recycle_fl_buf(struct freelQ > > *

Re: [PATCH 3/3] chelsio: more rx speedup

2007-01-09 Thread Ingo Oeser
Hi Stephen, Stephen Hemminger schrieb: > --- netdev-2.6.orig/drivers/net/chelsio/sge.c > +++ netdev-2.6/drivers/net/chelsio/sge.c [...] > @@ -1043,45 +1046,42 @@ static void recycle_fl_buf(struct freelQ > * be copied but there is no memory for the copy. > */ > static inline struct sk_buff *

[PATCH 3/3] chelsio: more rx speedup

2007-01-08 Thread Stephen Hemminger
Cleanup receive processing some more: * do the reserve padding of skb during setup * don't pass constants to get_packet * do smart prefetch of skb * make copybreak a module parameter Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/chelsio/sge.c | 87 +++