RE: [PATCH 25/26] net: pass a sockptr_t into ->setsockopt

2020-08-08 Thread David Laight
From: Eric Dumazet > Sent: 07 August 2020 19:29 > > On 8/7/20 2:18 AM, David Laight wrote: > > From: Eric Dumazet > >> Sent: 06 August 2020 23:21 > >> > >> On 7/22/20 11:09 PM, Christoph Hellwig wrote: > >>> Rework the remaining setsockopt code to pass a sockptr_t instead of a > >>> plain user poi

Re: [PATCH 25/26] net: pass a sockptr_t into ->setsockopt

2020-08-07 Thread Eric Dumazet
On 8/7/20 2:18 AM, David Laight wrote: > From: Eric Dumazet >> Sent: 06 August 2020 23:21 >> >> On 7/22/20 11:09 PM, Christoph Hellwig wrote: >>> Rework the remaining setsockopt code to pass a sockptr_t instead of a >>> plain user pointer. This removes the last remaining set_fs(KERNEL_DS) >>> o

RE: [PATCH 25/26] net: pass a sockptr_t into ->setsockopt

2020-08-07 Thread David Laight
From: Eric Dumazet > Sent: 06 August 2020 23:21 > > On 7/22/20 11:09 PM, Christoph Hellwig wrote: > > Rework the remaining setsockopt code to pass a sockptr_t instead of a > > plain user pointer. This removes the last remaining set_fs(KERNEL_DS) > > outside of architecture specific code. > > > >

Re: [PATCH 25/26] net: pass a sockptr_t into ->setsockopt

2020-08-07 Thread Christoph Hellwig
On Thu, Aug 06, 2020 at 03:21:25PM -0700, Eric Dumazet wrote: > converting get_user(...) to copy_from_sockptr(...) really assumed the > optlen > has been validated to be >= sizeof(int) earlier. > > Which is not always the case, for example here. Yes. And besides the bpfilter mess the main re

Re: [PATCH 25/26] net: pass a sockptr_t into ->setsockopt

2020-08-06 Thread Eric Dumazet
On 7/22/20 11:09 PM, Christoph Hellwig wrote: > Rework the remaining setsockopt code to pass a sockptr_t instead of a > plain user pointer. This removes the last remaining set_fs(KERNEL_DS) > outside of architecture specific code. > > Signed-off-by: Christoph Hellwig > Acked-by: Stefan Schmid

Re: [MPTCP] [PATCH 25/26] net: pass a sockptr_t into ->setsockopt

2020-07-23 Thread Matthieu Baerts
Hi Christoph, On 23/07/2020 08:09, Christoph Hellwig wrote: Rework the remaining setsockopt code to pass a sockptr_t instead of a plain user pointer. This removes the last remaining set_fs(KERNEL_DS) outside of architecture specific code. Signed-off-by: Christoph Hellwig Acked-by: Stefan Schm

[PATCH 25/26] net: pass a sockptr_t into ->setsockopt

2020-07-22 Thread Christoph Hellwig
Rework the remaining setsockopt code to pass a sockptr_t instead of a plain user pointer. This removes the last remaining set_fs(KERNEL_DS) outside of architecture specific code. Signed-off-by: Christoph Hellwig Acked-by: Stefan Schmidt [ieee802154] --- crypto/af_alg.c