Stephen,
Thank you for taking the time to go over this.
Stephen Hemminger wrote:
1. Please use dev_err() to help user figure out which board has problem:
OK
2. Use new MAC_ADDR() rather than
OK
3. The reset task logic needs more cleanup/protection.
OK
4. Rather than hard coding mac add
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:03:49 -0800
> 1. Please use dev_err() to help user figure out which board has problem:
> Not:
> printk(KERN_ERR PFX "Cannot register net device\n");
> Instead:
> dev_err(&pdev->dev, "cannot register n
1. Please use dev_err() to help user figure out which board has problem:
Not:
printk(KERN_ERR PFX "Cannot register net device\n");
Instead:
dev_err(&pdev->dev, "cannot register net device\n");
2. Use new MAC_ADDR() rather than
printk("node addr ");
