Re: [PATCH 2.6.24] tg3: fix ethtool autonegotiate flags

2007-10-08 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 02 Oct 2007 15:02:56 -0700 > On Tue, 2007-10-02 at 16:16 -0400, Andy Gospodarek wrote: > > Adding that flag in tg3_set_settings seemed like the most logical > > place > > since the driver works fine on boot. This is just an issue when > > re-ena

Re: [PATCH 2.6.24] tg3: fix ethtool autonegotiate flags

2007-10-02 Thread Andy Gospodarek
On Tue, Oct 02, 2007 at 03:02:56PM -0700, Michael Chan wrote: > On Tue, 2007-10-02 at 16:16 -0400, Andy Gospodarek wrote: > > Adding that flag in tg3_set_settings seemed like the most logical > > place > > since the driver works fine on boot. This is just an issue when > > re-enabling autonegotiat

Re: [PATCH 2.6.24] tg3: fix ethtool autonegotiate flags

2007-10-02 Thread Michael Chan
On Tue, 2007-10-02 at 16:16 -0400, Andy Gospodarek wrote: > Adding that flag in tg3_set_settings seemed like the most logical > place > since the driver works fine on boot. This is just an issue when > re-enabling autonegotiation, so we should probably nip it there. > > Signed-off-by: Andy Gospod

[PATCH 2.6.24] tg3: fix ethtool autonegotiate flags

2007-10-02 Thread Andy Gospodarek
I recently noticed that when calling: # ethtool -s eth0 autoneg on on a 5722 (though I'm sure it's not specific to that card) that subsequent checks of the cards status looked like this: # ethtool eth0 Settings for eth0: Supported ports: [ MII ] Supported link modes: 10baseT/H