Re: [PATCH 2.6.21-rc5] bnx2: fix buffer overrun in bnx2_nvram_write

2007-03-29 Thread Michael Chan
On Thu, 2007-03-29 at 22:47 +, Cureington, Tony wrote: > A buffer overrun issue exists in the bnx2_nvram_write function. Tony, thanks for the patch. The alignment logic is indeed still broken despite trying to fix it before. I think the following patch is better in fixing the alignment logic

[PATCH 2.6.21-rc5] bnx2: fix buffer overrun in bnx2_nvram_write

2007-03-29 Thread Cureington, Tony
A buffer overrun issue exists in the bnx2_nvram_write function. This issue is exposed by calling ethtool to write to the eeprom as shown below. ethtool -E eth4 magic 0x669955AA offset 0x137 value 0xC4 The problem happens when align_buf is allocated only 2 bytes in the kmalloc call and later 4