Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 3

2006-12-07 Thread Stephen Hemminger
On 05 Dec 2006 09:29:52 +0200 Andrew Victor <[EMAIL PROTECTED]> wrote: > hi Stephen, > > > Use netdev_alloc_skb instead. It sets skb->dev so you don't have to. > > netdev_alloc_skb() seems to cause 2 function calls [__netdev_alloc_skb() > and __alloc_skb()], instead of just 1 for the dev_alloc_s

Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 3

2006-12-04 Thread Andrew Victor
hi Stephen, > Use netdev_alloc_skb instead. It sets skb->dev so you don't have to. netdev_alloc_skb() seems to cause 2 function calls [__netdev_alloc_skb() and __alloc_skb()], instead of just 1 for the dev_alloc_skb() case. It might be more efficient if the driver manually sets skb->dev. > Sett

Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 3

2006-12-04 Thread Jeff Garzik
Andrew Victor wrote: A minor fix to the Atmel AT91RM9200 Ethernet driver. 1. Use dev_alloc_skb() instead of alloc_skb(). 2. It is not necessary to adjust skb->len manually. Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> ACK patch content - To unsubscribe from this list: send the line "un

Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 3

2006-12-04 Thread Stephen Hemminger
On 04 Dec 2006 14:50:24 +0200 Andrew Victor <[EMAIL PROTECTED]> wrote: > A minor fix to the Atmel AT91RM9200 Ethernet driver. > > 1. Use dev_alloc_skb() instead of alloc_skb(). > 2. It is not necessary to adjust skb->len manually. > > > Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> > > > d

[PATCH 2.6.19] AT91RM9200 Ethernet update 3

2006-12-04 Thread Andrew Victor
A minor fix to the Atmel AT91RM9200 Ethernet driver. 1. Use dev_alloc_skb() instead of alloc_skb(). 2. It is not necessary to adjust skb->len manually. Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> diff -urN linux-2.6.19-final.orig/drivers/net/arm/at91_ether.c linux-2.6.19-final/drivers/ne