Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 1

2006-12-04 Thread Jeff Garzik
NAK. see inline comments in quoted text. Andrew Victor wrote: Please fix your email's subject line per http://linux.yyz.us/patch-format.html The subject is a one-line summary that tells us not only what driver is being update, but also summarizes the changes in the patch. "update 1" tell

Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 1

2006-12-04 Thread Stephen Hemminger
On 04 Dec 2006 14:26:57 +0200 Andrew Victor <[EMAIL PROTECTED]> wrote: > This patch is an update to the Atmel AT91RM9200 Ethernet driver. > > 1. Remove the global 'at91_dev' variable. > 2. Move the global 'check_timer' variable into the private data > structure. > > > Signed-off-by: Andrew Vic

[PATCH 2.6.19] AT91RM9200 Ethernet update 1

2006-12-04 Thread Andrew Victor
This patch is an update to the Atmel AT91RM9200 Ethernet driver. 1. Remove the global 'at91_dev' variable. 2. Move the global 'check_timer' variable into the private data structure. Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> diff -urN linux-2.6.19-final.orig/drivers/net/arm/at91_ether.c