diff -Narup -X linux-2.6.17.orig/Documentation/dontdiff
linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hw.c
linux-2.6.17/drivers/net/netxen/netxen_nic_hw.c
--- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hw.c1969-12-31
16:00:00.0 -0800
+++ linux-2.6.17/drivers/net/netxen/ne
On Monday 21 August 2006 19:33, Stephen Hemminger wrote:
> On Mon, 21 Aug 2006 13:57:23 +0530
>
> "Amit S. Kale" <[EMAIL PROTECTED]> wrote:
> > We can certainly create a table for all error messages. It'll hurt
> > readability of code in many of the other places where printks are used to
> > indica
On Mon, 2006-08-21 at 07:03 -0700, Stephen Hemminger wrote:
> On Mon, 21 Aug 2006 13:57:23 +0530
> "Amit S. Kale" <[EMAIL PROTECTED]> wrote:
>
> > We can certainly create a table for all error messages. It'll hurt
> > readability
> > of code in many of the other places where printks are used to
On Mon, 21 Aug 2006 13:57:23 +0530
"Amit S. Kale" <[EMAIL PROTECTED]> wrote:
> We can certainly create a table for all error messages. It'll hurt
> readability
> of code in many of the other places where printks are used to indicate some
> hardware error.
> -Amit
My suggestion was intended as
diff -u linux-2.6.17/drivers/net/netxen/netxen_nic_hw.c
linux-2.6.17/drivers/net/netxen/netxen_nic_hw.c
--- linux-2.6.17/drivers/net/netxen/netxen_nic_hw.c 2006-08-17
07:12:34.0 -0700
+++ linux-2.6.17/drivers/net/netxen/netxen_nic_hw.c 2006-08-21
02:20:00.0 -0700
@@ -31
We can certainly create a table for all error messages. It'll hurt readability
of code in many of the other places where printks are used to indicate some
hardware error.
-Amit
On Friday 18 August 2006 20:46, Stephen Hemminger wrote:
> > + if (fw_major != _NETXEN_NIC_LINUX_MAJOR) {
> > +
Way to many DPRINTK()'s
> +
> +int is_flash_supported(struct netxen_adapter *adapter)
needs to be static or prefixed.
> +{
> + int locs[] = { 0, 0x4, 0x100, 0x4000, 0x4128 };
use const
> + int addr, val01, val02, i, j;
> +
> + /* if the flash size less than 4Mb, make huge war cry
diff -Nrup -X linux-2.6.17.orig/Documentation/dontdiff
linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hw.c
linux-2.6.17/drivers/net/netxen/netxen_nic_hw.c
--- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hw.c1969-12-31
16:00:00.0 -0800
+++ linux-2.6.17/drivers/net/netxen/net
