Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-08-27 Thread Joe Perches
On Thu, 2020-08-27 at 12:27 +0300, Kalle Valo wrote: > Larry Finger writes: > > On 7/27/20 9:52 AM, Joe Perches wrote: > > > On Mon, 2020-07-27 at 09:04 +, Pkshih wrote: > > > > So, I think you would like to have parenthesis intentionally. > > > > If so, > > > > test1 ? : (test2 ? :) > > > > w

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-08-27 Thread Kalle Valo
Larry Finger writes: > On 7/27/20 9:52 AM, Joe Perches wrote: >> On Mon, 2020-07-27 at 09:04 +, Pkshih wrote: >>> So, I think you would like to have parenthesis intentionally. >>> If so, >>> test1 ? : (test2 ? :) >>> would be better. >>> >>> >>> If not, >>> test1 ? : test2 ? : >>> may be what

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-07-27 Thread Joe Perches
On Mon, 2020-07-27 at 11:25 -0500, Larry Finger wrote: > On 7/27/20 9:52 AM, Joe Perches wrote: > > On Mon, 2020-07-27 at 09:04 +, Pkshih wrote: > > > So, I think you would like to have parenthesis intentionally. > > > If so, > > > test1 ? : (test2 ? :) > > > would be better. > > > > > > > >

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-07-27 Thread Larry Finger
On 7/27/20 9:52 AM, Joe Perches wrote: On Mon, 2020-07-27 at 09:04 +, Pkshih wrote: So, I think you would like to have parenthesis intentionally. If so, test1 ? : (test2 ? :) would be better. If not, test1 ? : test2 ? : may be what you want (without any parenthesis). Use whatever style y

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-07-27 Thread Joe Perches
On Mon, 2020-07-27 at 09:04 +, Pkshih wrote: > So, I think you would like to have parenthesis intentionally. > If so, > test1 ? : (test2 ? :) > would be better. > > > If not, > test1 ? : test2 ? : > may be what you want (without any parenthesis). Use whatever style you like, it's unimportan

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-07-27 Thread Pkshih
On Mon, 2020-07-27 at 01:27 -0700, Joe Perches wrote: > On Mon, 2020-07-27 at 06:07 +, Pkshih wrote: > > On Sat, 2020-07-25 at 12:55 -0700, Joe Perches wrote: > > > Make these statements a little simpler. > [] > > > diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > []

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-07-27 Thread Joe Perches
On Mon, 2020-07-27 at 06:07 +, Pkshih wrote: > On Sat, 2020-07-25 at 12:55 -0700, Joe Perches wrote: > > Make these statements a little simpler. [] > > diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c [] > > @@ -874,11 +874,10 @@ static void halbtc_display_wifi_status(

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-07-26 Thread Pkshih
On Sat, 2020-07-25 at 12:55 -0700, Joe Perches wrote: > Make these statements a little simpler. > > Signed-off-by: Joe Perches > --- >  drivers/net/wireless/realtek/rtlwifi/base.c   | 14 +-- >  .../rtlwifi/btcoexist/halbtc8192e2ant.c   | 23 ++- >  .../rtlwifi/btcoexist

[PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-07-25 Thread Joe Perches
Make these statements a little simpler. Signed-off-by: Joe Perches --- drivers/net/wireless/realtek/rtlwifi/base.c | 14 +-- .../rtlwifi/btcoexist/halbtc8192e2ant.c | 23 ++- .../rtlwifi/btcoexist/halbtc8821a2ant.c | 12 +- .../realtek/rtlwifi/btcoex