Re: [PATCH 2/4] of: phy: Warn about unexpected fixed-links in of_mdiobus_register

2018-08-20 Thread Ahmad Fatoum
On 08/20/2018 03:37 PM, Andrew Lunn wrote: > We should be more specific than "device tree". It is actually the "mdio bus > subtree". I wasn't sure if there are more drivers that call of_mdiobus_register for the MAC node. I'll update the message. > Is this patch on its own sufficient to fix your

Re: [PATCH 2/4] of: phy: Warn about unexpected fixed-links in of_mdiobus_register

2018-08-20 Thread Andrew Lunn
On Mon, Aug 20, 2018 at 02:12:36PM +0200, Ahmad Fatoum wrote: > fixed-links are currently not handled by of_mdiobus_register, > skip them with a warning instead of trying pointlessly to find their PHY > address: > > libphy: MACB_mii_bus: probed > mdio_bus f0028000.ethernet-: fi

Re: [PATCH 2/4] of: phy: Warn about unexpected fixed-links in of_mdiobus_register

2018-08-20 Thread Ahmad Fatoum
On 08/20/2018 02:12 PM, Ahmad Fatoum wrote: > /* Loop over the child nodes and register a phy_device for each phy */ > for_each_available_child_of_node(np, child) { > + if (of_phy_is_fixed_link(np)) { > + /* fixed-links are handled in the MAC drivers */ >

[PATCH 2/4] of: phy: Warn about unexpected fixed-links in of_mdiobus_register

2018-08-20 Thread Ahmad Fatoum
fixed-links are currently not handled by of_mdiobus_register, skip them with a warning instead of trying pointlessly to find their PHY address: libphy: MACB_mii_bus: probed mdio_bus f0028000.ethernet-: fixed-link has invalid PHY address mdio_bus f0028000.ethernet-ff