Re: [PATCH 2/4] net: smsc911x: Fix register_netdev, phy startup, driver unload ordering

2016-09-03 Thread Sergei Shtylyov
On 09/01/2016 11:15 PM, Jeremy Linton wrote: Move phy startup/shutdown into the smsc911x_open/stop routines. This allows the module to be unloaded because phy_connect_direct is no longer always holding the module use count. This one change also resolves a number of other problems. The link stat

[PATCH 2/4] net: smsc911x: Fix register_netdev, phy startup, driver unload ordering

2016-09-01 Thread Jeremy Linton
Move phy startup/shutdown into the smsc911x_open/stop routines. This allows the module to be unloaded because phy_connect_direct is no longer always holding the module use count. This one change also resolves a number of other problems. The link status of a downed interface no longer reflects a st

Re: [PATCH 2/4] net: smsc911x: Fix register_netdev, phy startup, driver unload ordering

2016-09-01 Thread Andrew Lunn
> @@ -1604,7 +1599,7 @@ static int smsc911x_open(struct net_device *dev) > netdev_warn(dev, "ISR failed signaling test (IRQ %d)\n", > dev->irq); > retval = -ENODEV; > - goto out; > + goto mii_free_out; A nit pick, but it