Re: [PATCH 2/4] dsmark: get rid of trivial function

2008-01-21 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 21 Jan 2008 19:47:51 -0800 > > > > indices = RTA_GET_U16(tb[TCA_DSMARK_INDICES-1]); > > - if (!indices || !dsmark_valid_indices(indices)) > > + > > + if (hweight32(indices) != 1) > > goto errout; > > Come on Dave, that i

Re: [PATCH 2/4] dsmark: get rid of trivial function

2008-01-21 Thread Stephen Hemminger
On Mon, 21 Jan 2008 02:22:23 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Mon, 21 Jan 2008 01:16:32 +0100 > > > Stephen Hemminger wrote: > > > Replace loop in dsmark_valid_indices with equivalent bit math. > > > > > > Signed-off-by: Step

Re: [PATCH 2/4] dsmark: get rid of trivial function

2008-01-21 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 21 Jan 2008 01:16:32 +0100 > Stephen Hemminger wrote: > > Replace loop in dsmark_valid_indices with equivalent bit math. > > > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > > > --- a/net/sched/sch_dsmark.c2008-01-20 13:07:

Re: [PATCH 2/4] dsmark: get rid of trivial function

2008-01-21 Thread Ilpo Järvinen
On Mon, 21 Jan 2008, Patrick McHardy wrote: > Stephen Hemminger wrote: > > Replace loop in dsmark_valid_indices with equivalent bit math. > > > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > > > --- a/net/sched/sch_dsmark.c2008-01-20 13:07:58.0 -0800 > > +++ b/net/sch

Re: [PATCH 2/4] dsmark: get rid of trivial function

2008-01-20 Thread Patrick McHardy
Stephen Hemminger wrote: Replace loop in dsmark_valid_indices with equivalent bit math. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/sched/sch_dsmark.c2008-01-20 13:07:58.0 -0800 +++ b/net/sched/sch_dsmark.c2008-01-20 13:22:54.0 -0800 @@ -45,13 +45,8 @@

[PATCH 2/4] dsmark: get rid of trivial function

2008-01-20 Thread Stephen Hemminger
Replace loop in dsmark_valid_indices with equivalent bit math. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/sched/sch_dsmark.c2008-01-20 13:07:58.0 -0800 +++ b/net/sched/sch_dsmark.c2008-01-20 13:22:54.0 -0800 @@ -45,13 +45,8 @@ struct dsmark_qdisc_data {