Re: [PATCH 2/4] amd-xgbe: Fix NETDEV WATCHDOG transmit queue timeout warning

2021-02-12 Thread Tom Lendacky
On 2/12/21 12:00 PM, Shyam Sundar S K wrote: Current driver calls the netif_carrier_off() during the later point in time to tear down the link which causes the netdev watchdog to timeout. This is a bit confusing... how about: The current driver calls netif_carrier_off() late in the link tear

[PATCH 2/4] amd-xgbe: Fix NETDEV WATCHDOG transmit queue timeout warning

2021-02-12 Thread Shyam Sundar S K
Current driver calls the netif_carrier_off() during the later point in time to tear down the link which causes the netdev watchdog to timeout. Calling netif_carrier_off() immediately after netif_tx_stop_all_queues() would avoids the warning. [ cut here ] NETDEV WATCHDOG: