[v2 PATCH 2/3] tipc: Fix tipc_sk_reinit race conditions

2017-02-11 Thread Herbert Xu
There are two problems with the function tipc_sk_reinit. Firstly it's doing a manual walk over an rhashtable. This is broken as an rhashtable can be resized and if you manually walk over it during a resize then you may miss entries. Secondly it's missing memory barriers as previously the code us

Re: [PATCH 2/3] tipc: Fix tipc_sk_reinit race conditions

2017-02-10 Thread Ying Xue
On 02/07/2017 08:39 PM, Herbert Xu wrote: > There are two problems with the function tipc_sk_reinit. Firstly > it's doing a manual walk over an rhashtable. This is broken as > an rhashtable can be resized and if you manually walk over it > during a resize then you may miss entries. > > Secondly

[PATCH 2/3] tipc: Fix tipc_sk_reinit race conditions

2017-02-07 Thread Herbert Xu
There are two problems with the function tipc_sk_reinit. Firstly it's doing a manual walk over an rhashtable. This is broken as an rhashtable can be resized and if you manually walk over it during a resize then you may miss entries. Secondly it's missing memory barriers as previously the code us