Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-06 Thread Michael Buesch
On Monday 05 June 2006 22:53, Greg KH wrote: > On Mon, Jun 05, 2006 at 10:20:07PM +0200, Jiri Slaby wrote: > > bcm43xx avoid pci_find_device > > > > Change pci_find_device to safer pci_get_device with support for more > > devices. > > > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> > > > > ---

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Greg KH
On Mon, Jun 05, 2006 at 09:18:18PM -0400, Jeff Garzik wrote: > On Mon, Jun 05, 2006 at 01:53:09PM -0700, Greg KH wrote: > > Why not just use the proper pci interface? Why poke around in another > > pci device to steal an irq, when that irq might not even be valid? > > (irqs are not valid until pci

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Jeff Garzik
On Mon, Jun 05, 2006 at 01:53:09PM -0700, Greg KH wrote: > Why not just use the proper pci interface? Why poke around in another > pci device to steal an irq, when that irq might not even be valid? > (irqs are not valid until pci_enable_device() is called on them...) Answered this question the la

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Jiri Slaby
Greg KH napsal(a): > On Mon, Jun 05, 2006 at 10:20:07PM +0200, Jiri Slaby wrote: >> bcm43xx avoid pci_find_device >> >> Change pci_find_device to safer pci_get_device with support for more >> devices. >> >> Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> >> >> --- >> commit 4b73c16f5411d97360d5f26f29

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Greg KH
On Mon, Jun 05, 2006 at 10:20:07PM +0200, Jiri Slaby wrote: > bcm43xx avoid pci_find_device > > Change pci_find_device to safer pci_get_device with support for more > devices. > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> > > --- > commit 4b73c16f5411d97360d5f26f292ffddeb670ff75 > tree 6e43c

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Jiri Slaby
Michael Buesch napsal(a): > On Monday 05 June 2006 22:18, Jiri Slaby wrote: >> bcm43xx avoid pci_find_device >> >> Change pci_find_device to safer pci_get_device with support for more >> devices. > > I am wondering about the reference count. > From docbook: > > 256 * pci_get_device - begin or co

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Michael Buesch
On Monday 05 June 2006 22:18, Jiri Slaby wrote: > bcm43xx avoid pci_find_device > > Change pci_find_device to safer pci_get_device with support for more > devices. I am wondering about the reference count. >From docbook: 256 * pci_get_device - begin or continue searching for a PCI device by ve

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Jiri Slaby
John W. Linville napsal(a): > On Fri, May 26, 2006 at 01:29:12PM +0159, Jiri Slaby wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Jeff Garzik napsal(a): >>> Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): > The point i

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread John W. Linville
On Fri, May 26, 2006 at 01:29:12PM +0159, Jiri Slaby wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Jeff Garzik napsal(a): > > Jiri Slaby wrote: > >> -BEGIN PGP SIGNED MESSAGE- > >> Hash: SHA1 > >> > >> Jeff Garzik napsal(a): > >>> The point is that you don't need to loop ove

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jiri Slaby
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael Buesch napsal(a): > On Friday 26 May 2006 12:33, you wrote: >> --- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c >> +++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c >> @@ -2131,6 +2131,13 @@ out: >> return err; >> } >

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Michael Buesch
On Friday 26 May 2006 12:33, you wrote: > --- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c > +++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c > @@ -2131,6 +2131,13 @@ out: > return err; > } > > +#ifdef CONFIG_BCM947XX > +static struct pci_device_id bc

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jiri Slaby
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): > Jiri Slaby wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Jeff Garzik napsal(a): >>> The point is that you don't need to loop over the table, >>> pci_match_one_device() does that for you. >> The problem is, th

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jeff Garzik
Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): The point is that you don't need to loop over the table, pci_match_one_device() does that for you. The problem is, that there is no such function, I think. If you take a look at pci_dev_present: The functi

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jiri Slaby
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): > The point is that you don't need to loop over the table, > pci_match_one_device() does that for you. The problem is, that there is no such function, I think. If you take a look at pci_dev_present: http://sosdg.org/~coywolf/lxr/

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jeff Garzik
Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: bcm43xx avoid pci_find_device Change pci_find_device to safer pci_get_device with support for more

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jiri Slaby
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): > Jiri Slaby wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Jeff Garzik napsal(a): >>> Jiri Slaby wrote: bcm43xx avoid pci_find_device Change pci_find_device to safer pci_get_device with support f

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jeff Garzik
Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: bcm43xx avoid pci_find_device Change pci_find_device to safer pci_get_device with support for more devices. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 1d3b6caf027fe53351c64

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jiri Slaby
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): > Jiri Slaby wrote: >> bcm43xx avoid pci_find_device >> >> Change pci_find_device to safer pci_get_device with support for more >> devices. >> >> Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> >> >> --- >> commit 1d3b6caf027fe5335

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-25 Thread Jeff Garzik
Jiri Slaby wrote: bcm43xx avoid pci_find_device Change pci_find_device to safer pci_get_device with support for more devices. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 1d3b6caf027fe53351c645523587aeac40bc3e47 tree ae37c86b633442cdf8a7a19ac287542724081c90 parent ab3443d79c94d0ae6