Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-12 Thread subashab
On 2021-02-12 12:06, Alex Elder wrote: On 2/12/21 12:51 PM, Jakub Kicinski wrote: On Fri, 12 Feb 2021 08:01:15 -0600 Alex Elder wrote: On 2/11/21 8:04 PM, Jakub Kicinski wrote: On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: +/* MAP CSUM headers */ +struct rmnet_map_v5_csum

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-12 Thread Alex Elder
On 2/12/21 12:51 PM, Jakub Kicinski wrote: On Fri, 12 Feb 2021 08:01:15 -0600 Alex Elder wrote: On 2/11/21 8:04 PM, Jakub Kicinski wrote: On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: +/* MAP CSUM headers */ +struct rmnet_map_v5_csum_header { + u8 next_hdr:1; +

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-12 Thread Jakub Kicinski
On Fri, 12 Feb 2021 08:01:15 -0600 Alex Elder wrote: > On 2/11/21 8:04 PM, Jakub Kicinski wrote: > > On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: > >> +/* MAP CSUM headers */ > >> +struct rmnet_map_v5_csum_header { > >> + u8 next_hdr:1; > >> + u8 header_type:7; > >> + u

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-12 Thread subashab
On 2021-02-12 07:01, Alex Elder wrote: On 2/11/21 8:04 PM, Jakub Kicinski wrote: On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: +/* MAP CSUM headers */ +struct rmnet_map_v5_csum_header { + u8 next_hdr:1; + u8 header_type:7; + u8 hw_reserved:5; + u8

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-12 Thread Alex Elder
On 2/11/21 8:04 PM, Jakub Kicinski wrote: On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: +/* MAP CSUM headers */ +struct rmnet_map_v5_csum_header { + u8 next_hdr:1; + u8 header_type:7; + u8 hw_reserved:5; + u8 priority:1; + u8 hw_reserved_bi

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-11 Thread kernel test robot
Hi Sharath, Thank you for the patch! Yet something to improve: [auto build test ERROR on ipvs/master] [also build test ERROR on linus/master sparc-next/master v5.11-rc7 next-20210211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-11 Thread Jakub Kicinski
On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: > +/* MAP CSUM headers */ > +struct rmnet_map_v5_csum_header { > + u8 next_hdr:1; > + u8 header_type:7; > + u8 hw_reserved:5; > + u8 priority:1; > + u8 hw_reserved_bit:1; > + u8 csum_valid_required:1; >

[PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-11 Thread Sharath Chandra Vurukala
Adding support for processing of Mapv5 downlink packets. It involves parsing the Mapv5 packet and checking the csum header to know whether the hardware has validated the checksum and is valid or not. Based on the checksum valid bit the corresponding stats are incremented and skb->ip_summed is mark