Re: [PATCH 2/3] net: ethernet: bgmac: unify code of the same family

2017-02-03 Thread Rafał Miłecki
On 2017-02-03 22:39, Jon Mason wrote: BCM471X and BCM535X are of the same family (from what I can derive from internal documents). Group them into the case statement together, which results in more code reuse. Also, use existing helper variables to make the code a little more readable too. S

Re: [PATCH 2/3] net: ethernet: bgmac: unify code of the same family

2017-02-03 Thread Jon Mason
On Fri, Feb 3, 2017 at 4:48 PM, Rafał Miłecki wrote: > On 2017-02-03 22:39, Jon Mason wrote: >> >> BCM471X and BCM535X are of the same family (from what I can derive from >> internal documents). Group them into the case statement together, which >> results in more code reuse. >> >> Also, use exis

[PATCH 2/3] net: ethernet: bgmac: unify code of the same family

2017-02-03 Thread Jon Mason
BCM471X and BCM535X are of the same family (from what I can derive from internal documents). Group them into the case statement together, which results in more code reuse. Also, use existing helper variables to make the code a little more readable too. Signed-off-by: Jon Mason --- drivers/net/