Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

2007-04-30 Thread Atsushi Nemoto
On Sun, 29 Apr 2007 02:10:37 +0900 (JST), Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > > platform_device_register_simple() copies *res by value, so I believe we can > > make res[] static __initdata. This way we don't need to evaluate the array > > on the stack at runtime, and the data gets discard

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

2007-04-28 Thread Jeff Garzik
Atsushi Nemoto wrote: On Sat, 28 Apr 2007 11:10:37 -0400, Jeff Garzik <[EMAIL PROTECTED]> wrote: static unsigned int netcard_portlist[] __initdata = { - 0x300, 0x280, 0x320, 0x340, 0x360, 0x380, 0 +#if defined(CONFIG_ISA) || defined(CONFIG_M32R) + 0x300, 0x280, 0x320, 0x340, 0x360,

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

2007-04-28 Thread Atsushi Nemoto
On Sat, 28 Apr 2007 11:10:37 -0400, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > static unsigned int netcard_portlist[] __initdata = { > > - 0x300, 0x280, 0x320, 0x340, 0x360, 0x380, 0 > > +#if defined(CONFIG_ISA) || defined(CONFIG_M32R) > > + 0x300, 0x280, 0x320, 0x340, 0x360, 0x380, > > +#endi

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

2007-04-28 Thread Atsushi Nemoto
On Sat, 28 Apr 2007 01:04:14 -0700, Andrew Morton <[EMAIL PROTECTED]> wrote: > platform_device_register_simple() copies *res by value, so I believe we can > make res[] static __initdata. This way we don't need to evaluate the array > on the stack at runtime, and the data gets discarded after initc

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

2007-04-28 Thread Jeff Garzik
Atsushi Nemoto wrote: This patch lets RBTX49XX boards use generic platform_driver interface for the ne driver. * Use platform_device to pass ioaddr and irq to the ne driver. * Remove unnecessary ifdefs for RBTX49XX from the ne driver. * Make the ne driver selectable on these boards regardless of

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

2007-04-28 Thread Jeff Garzik
Atsushi Nemoto wrote: On Wed, 25 Apr 2007 01:55:49 +0900 (JST), Atsushi Nemoto <[EMAIL PROTECTED]> wrote: This patch lets RBTX49XX boards use generic platform_driver interface for the ne driver. This patch obsolates a patch I send on 1 Mar. Subject: [PATCH] Fix broken RBTX4927 support in ne

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

2007-04-28 Thread Andrew Morton
On Wed, 25 Apr 2007 01:55:49 +0900 (JST) Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > +static int __init rbtx4938_ne_init(void) > +{ > + struct resource res[] = { > + { > + .start = RBTX4938_RTL_8019_BASE, > + .end= RBTX4938_RTL_8019_BAS

[PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

2007-04-24 Thread Atsushi Nemoto
This patch lets RBTX49XX boards use generic platform_driver interface for the ne driver. * Use platform_device to pass ioaddr and irq to the ne driver. * Remove unnecessary ifdefs for RBTX49XX from the ne driver. * Make the ne driver selectable on these boards regardless of CONFIG_ISA * Add an ifd

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

2007-04-24 Thread Atsushi Nemoto
On Wed, 25 Apr 2007 01:55:49 +0900 (JST), Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > This patch lets RBTX49XX boards use generic platform_driver interface > for the ne driver. This patch obsolates a patch I send on 1 Mar. > Subject: [PATCH] Fix broken RBTX4927 support in ne.c > Message-Id: <[EM