Re: [PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk

2021-01-05 Thread Heiner Kallweit
On 06.01.2021 01:52, Russell King - ARM Linux admin wrote: > On Wed, Jan 06, 2021 at 01:44:03AM +0100, Heiner Kallweit wrote: >> The machine type check is there to protect from (theoretical) cases >> where the n2100 code (incl. the RTL8169 quirk) may be compiled in, >> but the kernel is used on ano

Re: [PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk

2021-01-05 Thread Russell King - ARM Linux admin
On Wed, Jan 06, 2021 at 01:44:03AM +0100, Heiner Kallweit wrote: > The machine type check is there to protect from (theoretical) cases > where the n2100 code (incl. the RTL8169 quirk) may be compiled in, > but the kernel is used on another machine. That is far from a theoretical case. The ARM port

Re: [PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk

2021-01-05 Thread Russell King - ARM Linux admin
On Tue, Jan 05, 2021 at 06:28:33PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 05, 2021 at 10:42:31AM +0100, Heiner Kallweit wrote: > > { > > - if (dev->bus->number == 0 && > > - (dev->devfn == PCI_DEVFN(1, 0) || > > -dev->devfn == PCI_DEVFN(2, 0))) > > - dev->broken_parity

Re: [PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk

2021-01-05 Thread Heiner Kallweit
On 06.01.2021 01:28, Bjorn Helgaas wrote: > On Tue, Jan 05, 2021 at 10:42:31AM +0100, Heiner Kallweit wrote: >> Simplify the quirk by using new PCI core function >> pci_quirk_broken_parity(). In addition make the quirk >> more specific, use device id 0x8169 instead of PCI_ANY_ID. >> >> Signed-off-b

Re: [PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk

2021-01-05 Thread Bjorn Helgaas
On Tue, Jan 05, 2021 at 10:42:31AM +0100, Heiner Kallweit wrote: > Simplify the quirk by using new PCI core function > pci_quirk_broken_parity(). In addition make the quirk > more specific, use device id 0x8169 instead of PCI_ANY_ID. > > Signed-off-by: Heiner Kallweit > --- > arch/arm/mach-iop32

[PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk

2021-01-05 Thread Heiner Kallweit
Simplify the quirk by using new PCI core function pci_quirk_broken_parity(). In addition make the quirk more specific, use device id 0x8169 instead of PCI_ANY_ID. Signed-off-by: Heiner Kallweit --- arch/arm/mach-iop32x/n2100.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff -