From: jamal <[EMAIL PROTECTED]>
Date: Sun, 21 Oct 2007 15:20:20 -0400
> A resubmit against net-2.6 from about an hour ago.
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majo
A resubmit against net-2.6 from about an hour ago.
cheers,
jamal
0002-NET_CLS_ACT-Use-skb_act_clone.txt
Description: application/mbox
On Tue, 2007-16-10 at 16:10 +0200, Patrick McHardy wrote:
> Herbert Xu wrote:
> > On Tue, Oct 16, 2007 at 09:22:31AM -0400, jamal wrote:
> >> Does the copying of tc_verd in __copy_skb_header() not cover that?
> >
> > Yep, I'm pretty sure it does.
> >
> > In fact this patch completely resolves my
Herbert Xu wrote:
On Tue, Oct 16, 2007 at 09:22:31AM -0400, jamal wrote:
Does the copying of tc_verd in __copy_skb_header() not cover that?
Yep, I'm pretty sure it does.
In fact this patch completely resolves my concerns about tc_verd.
Indeed, I was looking at the wrong tree :)
-
To unsubs
On Tue, Oct 16, 2007 at 09:22:31AM -0400, jamal wrote:
>
> Does the copying of tc_verd in __copy_skb_header() not cover that?
Yep, I'm pretty sure it does.
In fact this patch completely resolves my concerns about tc_verd.
Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~
On Tue, 2007-16-10 at 14:53 +0200, Patrick McHardy wrote:
> jamal wrote:
>
> [Can't quote for some reason ..]
Sorry, trying to be clever with git-format-patch but chickened out
sending using git-am - so patch was just attached (Dave seems to be
friendly to such an approach when he applies)
> I
jamal wrote:
[Can't quote for some reason ..]
I don't think this change is safe since we might loose the
redirect counter and have endless redirect loops. ipip for
example calls skb_realloc_headroom, which clones the skb
when delta > 0, so it seems we really need to copy tc_verd
in skb_clone().
cheers,
jamal
[NET_CLS_ACT] Use skb_act_clone
clean skb_clone of any signs of CONFIG_NET_CLS_ACT and
have mirred us skb_act_clone()
Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]>
---
net/core/skbuff.c |7 ---
net/sched/act_mirred.c |2 +-
2 files changed, 1 insertions(+), 8
