Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-11-10 Thread Barry Day
On Tue, Nov 08, 2016 at 09:29:07AM -0500, Jes Sorensen wrote: > Dave Jones writes: > > On Fri, Nov 04, 2016 at 09:56:00AM -0400, Jes Sorensen wrote: > >> > >> Joe Perches writes: > >> > On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: > >> >> Code is 80 characters wide, and comments are /*

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-11-10 Thread Jes Sorensen
Dave Jones writes: > On Fri, Nov 04, 2016 at 09:56:00AM -0400, Jes Sorensen wrote: >> >> Joe Perches writes: >> > On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: >> >> Code is 80 characters wide, and comments are /* */ never the ugly C++ >> >> crap. >> > >> > You might look at the recent L

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-11-04 Thread Jes Sorensen
Joe Perches writes: > On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: >> Code is 80 characters wide, and comments are /* */ never the ugly C++ >> crap. > > You might look at the recent Linus Torvalds authored commit > 5e467652ffef (?printk: re-organize log_output() to be more legible") > wh

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-11-03 Thread Larry Finger
On 11/03/2016 03:41 AM, Joe Perches wrote: On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: Code is 80 characters wide, and comments are /* */ never the ugly C++ crap. You might look at the recent Linus Torvalds authored commit 5e467652ffef (?printk: re-organize log_output() to be more l

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-11-03 Thread Joe Perches
On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: > Code is 80 characters wide, and comments are /* */ never the ugly C++ > crap. You might look at the recent Linus Torvalds authored commit 5e467652ffef (?printk: re-organize log_output() to be more legible") which does both of those: c99 // c

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-11-02 Thread David Miller
From: Larry Finger Date: Wed, 2 Nov 2016 20:00:03 -0500 > On 10/30/2016 05:21 AM, John Heenan wrote: >> Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to >> set >> macpower, is never 0xea. It is only ever 0x01 (first time after >> modprobe) >> using wpa_supplicant and 0x00 th

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-11-02 Thread Larry Finger
On 10/30/2016 05:21 AM, John Heenan wrote: Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set macpower, is never 0xea. It is only ever 0x01 (first time after modprobe) using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results occurs with 'Fix for authent

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-10-30 Thread Jes Sorensen
John Heenan writes: > Thanks for your reply. > > The code was tested on a Cube i9 which has an internal rtl8723bu. > > No other devices were tested. > > I am happy to accept in an ideal context hard coding macpower is > undesirable, the comment is undesirable and it is wrong to assume the > issue

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-10-30 Thread John Heenan
Thanks for your reply. The code was tested on a Cube i9 which has an internal rtl8723bu. No other devices were tested. I am happy to accept in an ideal context hard coding macpower is undesirable, the comment is undesirable and it is wrong to assume the issue is not unique to the rtl8723bu. You

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-10-30 Thread Jes Sorensen
John Heenan writes: > Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set > macpower, is never 0xea. It is only ever 0x01 (first time after modprobe) > using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results > occurs with 'Fix for authentication failure'

[PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-10-30 Thread John Heenan
Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set macpower, is never 0xea. It is only ever 0x01 (first time after modprobe) using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results occurs with 'Fix for authentication failure' [PATCH 1/2] in place. Whate