On Wed, Oct 21, 2020 at 5:28 PM Andrew Lunn wrote:
>
> > Actually, I'd also be interested [for this PHY], to report a
> > "significance impedance" detection, which is similar to the
> > short-detection that is already done.
>
> You can add that as just another element of the enum.
>
> > At first,
> Actually, I'd also be interested [for this PHY], to report a
> "significance impedance" detection, which is similar to the
> short-detection that is already done.
You can add that as just another element of the enum.
> At first, this report would sound like it could be interesting; but
> feel f
On Wed, Oct 21, 2020 at 5:09 PM Andrew Lunn wrote:
>
> > Signed-off-by: Alexandru Ardelean
>
removed my typo-ed email
> Hi Alexandru
>
> Overall, this looks good.
>
> > +static int adin_cable_test_report_trans(int result)
> > +{
> > + int mask;
> > +
> > + if (result & ADIN1300_CDIAG_RS
> Signed-off-by: Alexandru Ardelean
Hi Alexandru
Overall, this looks good.
> +static int adin_cable_test_report_trans(int result)
> +{
> + int mask;
> +
> + if (result & ADIN1300_CDIAG_RSLT_GOOD)
> + return ETHTOOL_A_CABLE_RESULT_CODE_OK;
> + if (result & ADIN1300_CDIAG_
The ADIN1300/ADIN1200 support cable diagnostics using TDR.
The cable fault detection is automatically run on all four pairs looking at
all combinations of pair faults by first putting the PHY in standby (clear
the LINK_EN bit, PHY_CTRL_3 register, Address 0x0017) and then enabling the
diagnostic c
