Re: [PATCH 2/2] net: netrom: refactor code in nr_add_node

2017-10-22 Thread Gustavo A. R. Silva
Quoting walter harms : Am 20.10.2017 18:06, schrieb Gustavo A. R. Silva: Hi Walter, Quoting walter harms : Am 19.10.2017 19:27, schrieb Gustavo A. R. Silva: Code refactoring in order to make the code easier to read and maintain. Signed-off-by: Gustavo A. R. Silva --- This code was tested

Re: [PATCH 2/2] net: netrom: refactor code in nr_add_node

2017-10-20 Thread Kevin Dawson
Hello all. My original response just went to Gustavo and Walter because I'm not much of a kernel hacker these days; it was mainly observations that may or may not have been helpful and I'm not a regular list contributor. Looks like I shouldn't have been so shy! On Fri, Oct 20, 2017 at 06:54:0

Re: [PATCH 2/2] net: netrom: refactor code in nr_add_node

2017-10-20 Thread walter harms
Am 20.10.2017 18:06, schrieb Gustavo A. R. Silva: > Hi Walter, > > Quoting walter harms : > >> Am 19.10.2017 19:27, schrieb Gustavo A. R. Silva: >>> Code refactoring in order to make the code easier to read and maintain. >>> >>> Signed-off-by: Gustavo A. R. Silva >>> --- >>> This code was test

Re: [PATCH 2/2] net: netrom: refactor code in nr_add_node

2017-10-20 Thread Gustavo A. R. Silva
Hi Walter, Quoting walter harms : Am 19.10.2017 19:27, schrieb Gustavo A. R. Silva: Code refactoring in order to make the code easier to read and maintain. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only (GCC 7.2.0 was used). net/netrom/nr_route.c | 63 +++

Re: [PATCH 2/2] net: netrom: refactor code in nr_add_node

2017-10-20 Thread walter harms
Am 19.10.2017 19:27, schrieb Gustavo A. R. Silva: > Code refactoring in order to make the code easier to read and maintain. > > Signed-off-by: Gustavo A. R. Silva > --- > This code was tested by compilation only (GCC 7.2.0 was used). > > net/netrom/nr_route.c | 63 > -

[PATCH 2/2] net: netrom: refactor code in nr_add_node

2017-10-19 Thread Gustavo A. R. Silva
Code refactoring in order to make the code easier to read and maintain. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only (GCC 7.2.0 was used). net/netrom/nr_route.c | 63 --- 1 file changed, 20 insertions(+), 43 dele