Re: [PATCH 2/2] l2tp: Add Protocol field compression

2018-12-16 Thread Guillaume Nault
On Sun, Dec 16, 2018 at 08:46:19PM +0200, Sam Protsenko wrote: > Hi Guillaume, > > On Sun, Dec 16, 2018 at 6:30 PM Guillaume Nault wrote: > > > > On Fri, Dec 14, 2018 at 11:12:42PM +0200, Sam Protsenko wrote: > > > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > > > in PP

Re: [PATCH 2/2] l2tp: Add Protocol field compression

2018-12-16 Thread Sam Protsenko
Hi Guillaume, On Sun, Dec 16, 2018 at 6:30 PM Guillaume Nault wrote: > > On Fri, Dec 14, 2018 at 11:12:42PM +0200, Sam Protsenko wrote: > > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > > in PPP packet should be transmitted without leading 0x00. See section > > 6.5 in R

Re: [PATCH 2/2] l2tp: Add Protocol field compression

2018-12-16 Thread Guillaume Nault
On Fri, Dec 14, 2018 at 11:12:42PM +0200, Sam Protsenko wrote: > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > in PPP packet should be transmitted without leading 0x00. See section > 6.5 in RFC 1661 for details. Let's compress protocol field if needed, > the same way it's

[PATCH 2/2] l2tp: Add Protocol field compression

2018-12-14 Thread Sam Protsenko
When Protocol Field Compression (PFC) is enabled, the "Protocol" field in PPP packet should be transmitted without leading 0x00. See section 6.5 in RFC 1661 for details. Let's compress protocol field if needed, the same way it's done in drivers/net/ppp/pptp.c. To actually enable PFC, one should is