Re: [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

2021-02-10 Thread Luca Coelho
Takashi Iwai wrote: > The ucode TLV data may be read-only and should be treated as const > pointers, but currently a few code forcibly cast to the writable > pointer unnecessarily. This gave developers a wrong impression as if > it can be modified, resulting in crashing regressions already a cou

Re: [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

2021-01-12 Thread Kalle Valo
"Coelho, Luciano" writes: > On Tue, 2021-01-12 at 17:05 +0100, Takashi Iwai wrote: >> On Tue, 12 Jan 2021 16:50:54 +0100, >> Kalle Valo wrote: >> > >> > Takashi Iwai writes: >> > >> > > The ucode TLV data may be read-only and should be treated as const >> > > pointers, but currently a few code

Re: [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

2021-01-12 Thread Coelho, Luciano
On Tue, 2021-01-12 at 17:05 +0100, Takashi Iwai wrote: > On Tue, 12 Jan 2021 16:50:54 +0100, > Kalle Valo wrote: > > > > Takashi Iwai writes: > > > > > The ucode TLV data may be read-only and should be treated as const > > > pointers, but currently a few code forcibly cast to the writable > > >

Re: [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

2021-01-12 Thread Takashi Iwai
On Tue, 12 Jan 2021 16:50:54 +0100, Kalle Valo wrote: > > Takashi Iwai writes: > > > The ucode TLV data may be read-only and should be treated as const > > pointers, but currently a few code forcibly cast to the writable > > pointer unnecessarily. This gave developers a wrong impression as if >

Re: [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

2021-01-12 Thread Kalle Valo
Takashi Iwai writes: > The ucode TLV data may be read-only and should be treated as const > pointers, but currently a few code forcibly cast to the writable > pointer unnecessarily. This gave developers a wrong impression as if > it can be modified, resulting in crashing regressions already a co

[PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

2021-01-12 Thread Takashi Iwai
The ucode TLV data may be read-only and should be treated as const pointers, but currently a few code forcibly cast to the writable pointer unnecessarily. This gave developers a wrong impression as if it can be modified, resulting in crashing regressions already a couple of times. This patch adds