Re: [PATCH 2/2] isdn: correctly check failed allocation

2015-10-15 Thread David Miller
From: Insu Yun Date: Thu, 15 Oct 2015 12:29:28 -0400 > Since skb_clone is memory allocation, it could be failed when lack of > resource. > Therefore, return value of skb_clone needs to be checked and handle error. > > Signed-off-by: Insu Yun > --- > drivers/isdn/mISDN/layer2.c | 6 ++ > 1

Re: [PATCH 2/2] isdn: correctly check failed allocation

2015-10-15 Thread isdn
Hi Insu, thanks for bringing up this issue again. I thought I did fix this a year ago, but seems it did not managed to sent it upstream. The patch do not fix this completly, since it will drop the original skb from the L2 I frame queue, so the transmission would lost an I-FRAME, which is not allo

[PATCH 2/2] isdn: correctly check failed allocation

2015-10-15 Thread Insu Yun
Since skb_clone is memory allocation, it could be failed when lack of resource. Therefore, return value of skb_clone needs to be checked and handle error. Signed-off-by: Insu Yun --- drivers/isdn/mISDN/layer2.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/isdn/mISDN/layer2.c