Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-22 Thread jesse\(建興\)
gt; To: "David Vrabel" <[EMAIL PROTECTED]> Cc: "Pekka Enberg" <[EMAIL PROTECTED]>; ; ; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Sunday, May 21, 2006 6:16 PM Subject: Re: [PATCH 2/2] ipg: redundancy with mii.h David Vrabel <[EMAIL PROTECTED]> :

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-21 Thread jesse\(建興\)
PROTECTED]> Cc: "Pekka Enberg" <[EMAIL PROTECTED]>; ; ; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Sunday, May 21, 2006 6:16 PM Subject: Re: [PATCH 2/2] ipg: redundancy with mii.h David Vrabel <[EMAIL PROTECTED]> : [...] > 0007-ipg-plug-leaks-in-the-err

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-21 Thread Francois Romieu
David Vrabel <[EMAIL PROTECTED]> : [...] > 0007-ipg-plug-leaks-in-the-error-path-of-ipg_nic_open.txt broke receive > since it was skipping the initialization of the Rx buffers. Patch attached. Oops. Applied to branch netdev-ipg of git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git (plea

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-21 Thread Pekka Enberg
Hi David, On 5/21/06, David Vrabel <[EMAIL PROTECTED]> wrote: Did anyone manage to get a response from IC Plus regarding the required Signed-off-by line? The current IP1000A driver maintainer at IC Plus is [EMAIL PROTECTED] I have no received confirmation if he can sign off or not yet.

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-20 Thread David Vrabel
Apologies for the (very) late response. 0007-ipg-plug-leaks-in-the-error-path-of-ipg_nic_open.txt broke receive since it was skipping the initialization of the Rx buffers. Patch attached. Did anyone manage to get a response from IC Plus regarding the required Signed-off-by line? David Vrab

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-04 Thread Francois Romieu
David Vrabel <[EMAIL PROTECTED]> : [...] > >ipg: replace #define with enum > > > >Added some underscores to improve readability. > > > >Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> > > Nack. Register names in code should match those used in the > documentation (even if

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-04 Thread Francois Romieu
Pekka Enberg <[EMAIL PROTECTED]> : [...] > My initial patches are here: > > http://www.cs.helsinki.fi/u/penberg/linux/ip1000/ Nice. Thanks. > I consider your tree the master now. Please let me know when you have > recreated the history, so I can clone your tree. Thanks. The new serie is availab

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-04 Thread Pekka Enberg
Pekka J Enberg <[EMAIL PROTECTED]> : > [...] > > maintain the tree, I can send you my patches so you can recreate the full > > history. The first steps were produced by quilt on the original > > out-of-tree driver, though, so they're probably not helpful. On Thu, 2006-05-04 at 01:35 +0200, Franc

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-03 Thread David Vrabel
Francois Romieu wrote: ipg: remove forward declarations It makes no sense in a new driver. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Ack. ipg: replace #define with enum Added some underscores to improve readability. Signed-off-by: Francois

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-03 Thread Francois Romieu
Pekka J Enberg <[EMAIL PROTECTED]> : [...] > maintain the tree, I can send you my patches so you can recreate the full > history. The first steps were produced by quilt on the original > out-of-tree driver, though, so they're probably not helpful. It will be welcome. I have added a few little t

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-02 Thread Pekka J Enberg
Hi Francois, On Tue, 2 May 2006, Francois Romieu wrote: > Btw the whole serie is available in branch 'netdev-ipg' at: > git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git > > The interim steps may be useful if testing reveals something wrong > (especially if it happens in a few weeks/mont

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-02 Thread Francois Romieu
Btw the whole serie is available in branch 'netdev-ipg' at: git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git The interim steps may be useful if testing reveals something wrong (especially if it happens in a few weeks/months). $ git rev-list --pretty ebf34c9b6fcd22338ef764b039b3ac55ed0e2

[PATCH 2/2] ipg: redundancy with mii.h

2006-05-02 Thread Francois Romieu
Replace a bunch of #define with their counterpart from mii.h Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/ipg.c | 82 ++--- drivers/net/ipg.h | 29 --- 2 files changed, 34 insertions(+), 77 deletions(-) e