Re: [PATCH 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

2015-04-19 Thread Mateusz Kulikowski
Hi Joe, On 19.04.2015 22:20, Joe Perches wrote: (...) >> +# check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr >> +if ($^V && $^V ge 5.10.0 && >> +$line =~ >> /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/s) { > > Plea

Re: [PATCH 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

2015-04-19 Thread Joe Perches
On Sun, 2015-04-19 at 21:04 +0200, Mateusz Kulikowski wrote: > Suggest using eth_zero_addr() or eth_broadcast_addr() if memset is used > instead. Hi Mateusz, this is OK but here are some notes: > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -5042,6 +5042,22 @@ sub process {

[PATCH 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

2015-04-19 Thread Mateusz Kulikowski
Suggest using eth_zero_addr() or eth_broadcast_addr() if memset is used instead. Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 16 1 file changed, 16 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3a1a01e..1fc0819 100755 --- a/scr