Re: [PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Martin KaFai Lau
On Fri, Apr 27, 2018 at 02:26:50PM -0700, Martin KaFai Lau wrote: > On Fri, Apr 27, 2018 at 11:31:36PM +0300, Dan Carpenter wrote: > > On Fri, Apr 27, 2018 at 10:21:17PM +0200, Daniel Borkmann wrote: > > > On 04/27/2018 09:39 PM, Dan Carpenter wrote: > > > > On Fri, Apr 27, 2018 at 10:55:46AM -0700

Re: [PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Martin KaFai Lau
On Fri, Apr 27, 2018 at 11:31:36PM +0300, Dan Carpenter wrote: > On Fri, Apr 27, 2018 at 10:21:17PM +0200, Daniel Borkmann wrote: > > On 04/27/2018 09:39 PM, Dan Carpenter wrote: > > > On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: > > >> On Fri, Apr 27, 2018 at 10:20:25AM -0700,

Re: [PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Dan Carpenter
On Fri, Apr 27, 2018 at 10:21:17PM +0200, Daniel Borkmann wrote: > On 04/27/2018 09:39 PM, Dan Carpenter wrote: > > On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: > >> On Fri, Apr 27, 2018 at 10:20:25AM -0700, Martin KaFai Lau wrote: > >>> On Fri, Apr 27, 2018 at 05:04:59PM +0300

Re: [PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Daniel Borkmann
On 04/27/2018 09:39 PM, Dan Carpenter wrote: > On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: >> On Fri, Apr 27, 2018 at 10:20:25AM -0700, Martin KaFai Lau wrote: >>> On Fri, Apr 27, 2018 at 05:04:59PM +0300, Dan Carpenter wrote: We know "err" is zero so we can remove these

Re: [PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Dan Carpenter
On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: > On Fri, Apr 27, 2018 at 10:20:25AM -0700, Martin KaFai Lau wrote: > > On Fri, Apr 27, 2018 at 05:04:59PM +0300, Dan Carpenter wrote: > > > We know "err" is zero so we can remove these and pull the code in one > > > indent level. >

Re: [PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Martin KaFai Lau
On Fri, Apr 27, 2018 at 10:20:25AM -0700, Martin KaFai Lau wrote: > On Fri, Apr 27, 2018 at 05:04:59PM +0300, Dan Carpenter wrote: > > We know "err" is zero so we can remove these and pull the code in one > > indent level. > > > > Signed-off-by: Dan Carpenter > Thanks for the simplification! > >

Re: [PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Martin KaFai Lau
On Fri, Apr 27, 2018 at 05:04:59PM +0300, Dan Carpenter wrote: > We know "err" is zero so we can remove these and pull the code in one > indent level. > > Signed-off-by: Dan Carpenter Thanks for the simplification! Acked-by: Martin KaFai Lau > --- > This applies to the BPF tree (linux-next) >

[PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Dan Carpenter
We know "err" is zero so we can remove these and pull the code in one indent level. Signed-off-by: Dan Carpenter --- This applies to the BPF tree (linux-next) diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index e631b6fd60d3..7cb0905f37c2 100644 --- a/kernel/bpf/btf.c +++ b/kernel/bpf/btf.c @@