Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-21 Thread Ingo Oeser
Trent Jaeger wrote: > > On Nov 17, 2005, at 8:42 PM, Chris Wright wrote: > > Little heavy on KERN_DEBUG printk's. Could you drop them (or perhaps > > use pr_debug instead)? > > You are right. Are there guidelines for when to use KERN_DEBUGs that > I should be aware of? Never. Just use pr_deb

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-18 Thread David S. Miller
From: Trent Jaeger <[EMAIL PROTECTED]> Date: Fri, 18 Nov 2005 14:07:32 -0500 > Removed KERN_DEBUG statements from patch (security/selinux/xfrm.c and > security/selinux/include/xfrm.h). Not consistent with SELinux and > not really useful anymore. I've created a 2.6.16 networking tree at:

[PATCH 2/2] LSM-IPSec Network Hooks

2005-11-18 Thread Trent Jaeger
Removed KERN_DEBUG statements from patch (security/selinux/xfrm.c and security/selinux/include/xfrm.h). Not consistent with SELinux and not really useful anymore. Regards, Trent. This patch series implements per packet access control via the extensi

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-18 Thread Trent Jaeger
Thanks for all your help, Herbert. Regards, Trent. On Nov 17, 2005, at 8:28 PM, Herbert Xu wrote: On Thu, Nov 17, 2005 at 06:42:29PM -0500, Trent Jaeger wrote: Patch with sock callback lock made unconditional. Previous send (earlier today, 11/17) was not the latest patch -- please disregar

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread Trent Jaeger
On Nov 17, 2005, at 8:42 PM, Chris Wright wrote: * Trent Jaeger ([EMAIL PROTECTED]) wrote: Patch with sock callback lock made unconditional. Previous send (earlier today, 11/17) was not the latest patch -- please disregard that patch. Little heavy on KERN_DEBUG printk's. Could you drop t

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 18 Nov 2005 12:28:40 +1100 > On Thu, Nov 17, 2005 at 06:42:29PM -0500, Trent Jaeger wrote: > > Patch with sock callback lock made unconditional. Previous send > > (earlier today, 11/17) was not the latest patch -- please disregard > > that patch. >

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread Chris Wright
* Trent Jaeger ([EMAIL PROTECTED]) wrote: > Patch with sock callback lock made unconditional. Previous send > (earlier today, 11/17) was not the latest patch -- please disregard > that patch. Little heavy on KERN_DEBUG printk's. Could you drop them (or perhaps use pr_debug instead)? thanks, -c

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread Herbert Xu
On Thu, Nov 17, 2005 at 06:42:29PM -0500, Trent Jaeger wrote: > Patch with sock callback lock made unconditional. Previous send > (earlier today, 11/17) was not the latest patch -- please disregard > that patch. > > Signed-off-by: Trent Jaeger <[EMAIL PROTECTED]> Looks very good. Thank you Tre

[PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread Trent Jaeger
Patch with sock callback lock made unconditional. Previous send (earlier today, 11/17) was not the latest patch -- please disregard that patch. Regards, Trent. --- This patch series implements per packet access control via the extension of the Linux Security Modules

[PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread Trent Jaeger
Made unconditional the locking of sk_callback_lock when extracting the security structure. PATCH 1/2 unchanged. Regards, Trent. -- This patch series implements per packet access control via the extension of the Linux Security Modules (LSM) interface by hooks in t

[PATCH 2/2] LSM-IPSec Network Hooks

2005-11-16 Thread Trent Jaeger
Added Signed-off by me and updated to latest kernel. Regards, Trent. -- This patch series implements per packet access control via the extension of the Linux Security Modules (LSM) interface by hooks in the XFRM and pfkey subsystems that leverage IPSec security

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-12 Thread Herbert Xu
On Tue, Nov 01, 2005 at 10:23:56AM -0500, James Morris wrote: > On Tue, 1 Nov 2005, Herbert Xu wrote: > > > > + if (dir == FLOW_DIR_IN) > > > + read_lock_bh(&sk->sk_callback_lock); > > > > You've probably explained this already, but I wasn't paying attention :) > > Why is the lock only ne

[PATCH 2/2] LSM-IPSec Network Hooks

2005-11-07 Thread Trent Jaeger
Hi, Format modifications for Linux patch style. Regards, Trent. -- This patch series implements per packet access control via the extension of the Linux Security Modules (LSM) interface by hooks in the XFRM and pfkey subsystems that leverage IPSec security associa