Re: [PATCH 2/2] Interface group match

2007-10-18 Thread Patrick McHardy
Laszlo Attila Toth wrote: Interface group values can be checked on both input and output interfaces. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/netfilter/xt_ifgroup.h | 18 ++ net/netfilter/Kconfig| 16 + net/netfilter/Makefile

[PATCH 2/2] Interface group match

2007-10-18 Thread Laszlo Attila Toth
Interface group values can be checked on both input and output interfaces. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/netfilter/xt_ifgroup.h | 18 ++ net/netfilter/Kconfig| 16 + net/netfilter/Makefile |1 + net/netfilter/

Re: [PATCH 2/2] Interface group match - netfilter part

2007-10-17 Thread Patrick McHardy
Laszlo Attila Toth wrote: Patrick McHardy írta: The input interface is only valid in PREROUTING, INPUT and FORWARD. Why don't you support output-interface matching? The new version supports output-interface, currently I'm rewriting iptables part. But I'm not sure what to do with the forward

Re: [PATCH 2/2] Interface group match - netfilter part

2007-10-17 Thread Laszlo Attila Toth
Patrick McHardy írta: Laszlo Attila Toth wrote: +static int match(const struct sk_buff *skb, + const struct net_device *in, + const struct net_device *out, + const struct xt_match *match, + const void *matchinfo, + int offset, + unsigned int protoff, + int *hot

Re: [PATCH 2/2] Interface group match - netfilter part

2007-10-16 Thread Jan Engelhardt
On Oct 16 2007 10:30, Patrick McHardy wrote: >> +static int match(const struct sk_buff *skb, Potential symbol clash, name it ifgroup_match() for example. >> + const struct net_device *in, >> + const struct net_device *out, >> + const struct xt_match *match, >> + const void *

Re: [PATCH 2/2] Interface group match - netfilter part

2007-10-16 Thread Laszlo Attila Toth
Patrick McHardy írta: Laszlo Attila Toth wrote: +static int match(const struct sk_buff *skb, + const struct net_device *in, + const struct net_device *out, + const struct xt_match *match, + const void *matchinfo, + int offset, + unsigned int protoff, + int *hot

Re: [PATCH 2/2] Interface group match - netfilter part

2007-10-16 Thread Patrick McHardy
Laszlo Attila Toth wrote: +static int match(const struct sk_buff *skb, + const struct net_device *in, + const struct net_device *out, + const struct xt_match *match, + const void *matchinfo, + int offset, + unsigned int protoff, + int *hotdrop) +{ + const

[PATCH 2/2] Interface group match - netfilter part

2007-10-16 Thread Laszlo Attila Toth
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/netfilter/xt_ifgroup.h | 11 + net/netfilter/Kconfig| 16 +++ net/netfilter/Makefile |1 + net/netfilter/xt_ifgroup.c | 78 ++ 4 files c