Re: [PATCH 2/2][MCAST] Fix for add_grec(...)

2005-11-09 Thread Yan Zheng
David Stevens wrote: Yan, I think your patch has some problems. Yan Zheng <[EMAIL PROTECTED]> wrote on 11/09/2005 03:58:20 AM: +#if 0 if (!*psf_list) { if (type == MLD2_ALLOW_NEW_SOURCES || type == MLD2_BLOCK_OLD_SOURCES) @@ -1474,12 +1477,15 @@ static struct sk_buf

Re: [PATCH 2/2][MCAST] Fix for add_grec(...)

2005-11-09 Thread David Stevens
Yan, I think your patch has some problems. Yan Zheng <[EMAIL PROTECTED]> wrote on 11/09/2005 03:58:20 AM: > +#if 0 > if (!*psf_list) { >if (type == MLD2_ALLOW_NEW_SOURCES || >type == MLD2_BLOCK_OLD_SOURCES) > @@ -1474,12 +1477,15 @@ static struct sk_buff *add_grec(

[PATCH 2/2][MCAST] Fix for add_grec(...)

2005-11-09 Thread Yan Zheng
Hi When ifmcaddr6's mca_sources is not NULL, but none of the sources in the list can be included in report, (For example: when filter mode is exclude and the only source in the list has include count greater than zero.) add_grec(...) may returns without add any data to the sk_buff. So MLD2_CHA