Re: [PATCH 17/21] orinoco_pci: use pci_iomap() for resources

2006-04-08 Thread Jeff Garzik
Pavel Roskin wrote: Quoting Francois Romieu <[EMAIL PROTECTED]>: Is there a reason why dev->mem_{start/end} should not be removed ? Is there a reason why it should? Is it going to be obsolete? It is slowly obsoleting for a few years (don't laugh...). It is preferred to store the relevant addre

Re: [PATCH 17/21] orinoco_pci: use pci_iomap() for resources

2006-04-07 Thread Pavel Roskin
Quoting Francois Romieu <[EMAIL PROTECTED]>: > > > Is there a reason why dev->mem_{start/end} should not be removed ? > > > > Is there a reason why it should? Is it going to be obsolete? > > It is slowly obsoleting for a few years (don't laugh...). It is preferred > to store the relevant address in

Re: [PATCH 17/21] orinoco_pci: use pci_iomap() for resources

2006-04-07 Thread Francois Romieu
Pavel Roskin <[EMAIL PROTECTED]> : > On Fri, 2006-04-07 at 23:36 +0200, Francois Romieu wrote: > > > > @@ -208,8 +205,8 @@ static int orinoco_pci_init_one(struct p > > > priv = netdev_priv(dev); > > > card = priv->card; > > > card->pci_ioaddr = pci_ioaddr; > > > - dev->mem_start = pci_iorang

Re: [PATCH 17/21] orinoco_pci: use pci_iomap() for resources

2006-04-07 Thread Pavel Roskin
On Fri, 2006-04-07 at 23:36 +0200, Francois Romieu wrote: > > @@ -208,8 +205,8 @@ static int orinoco_pci_init_one(struct p > > priv = netdev_priv(dev); > > card = priv->card; > > card->pci_ioaddr = pci_ioaddr; > > - dev->mem_start = pci_iorange; > > - dev->mem_end = pci_iorange + p

Re: [PATCH 17/21] orinoco_pci: use pci_iomap() for resources

2006-04-07 Thread Francois Romieu
Pavel Roskin <[EMAIL PROTECTED]> : [...] > diff --git a/drivers/net/wireless/orinoco_pci.c > b/drivers/net/wireless/orinoco_pci.c > index e57e92b..75df90f 100644 > --- a/drivers/net/wireless/orinoco_pci.c > +++ b/drivers/net/wireless/orinoco_pci.c > @@ -170,9 +170,7 @@ static int orinoco_pci_init_

[PATCH 17/21] orinoco_pci: use pci_iomap() for resources

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco_pci.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/orinoco_pci.c b/drivers/net/wireless/orinoco_pci.c index e57e