Re: [PATCH 17/18] net: iosm: readme file

2021-01-22 Thread Andrew Lunn
On Wed, Jan 20, 2021 at 07:34:48PM -0600, Dan Williams wrote: > On Wed, 2021-01-20 at 15:32 -0800, Jakub Kicinski wrote: > > On Wed, 20 Jan 2021 20:34:51 +0100 Andrew Lunn wrote: > > > On Sun, Jan 17, 2021 at 06:26:54PM +0100, Bjørn Mork wrote: > > > > I was young and stupid. Now I'm not that young

Re: [PATCH 17/18] net: iosm: readme file

2021-01-20 Thread Dan Williams
On Wed, 2021-01-20 at 15:32 -0800, Jakub Kicinski wrote: > On Wed, 20 Jan 2021 20:34:51 +0100 Andrew Lunn wrote: > > On Sun, Jan 17, 2021 at 06:26:54PM +0100, Bjørn Mork wrote: > > > I was young and stupid. Now I'm not that young anymore ;-) > > > > We all make mistakes, when we don't have the k

Re: [PATCH 17/18] net: iosm: readme file

2021-01-20 Thread Jakub Kicinski
On Wed, 20 Jan 2021 20:34:51 +0100 Andrew Lunn wrote: > On Sun, Jan 17, 2021 at 06:26:54PM +0100, Bjørn Mork wrote: > > I was young and stupid. Now I'm not that young anymore ;-) > > We all make mistakes, when we don't have the knowledge there are other > ways. That is partially what code review

Re: [PATCH 17/18] net: iosm: readme file

2021-01-20 Thread Andrew Lunn
On Sun, Jan 17, 2021 at 06:26:54PM +0100, Bjørn Mork wrote: > I was young and stupid. Now I'm not that young anymore ;-) We all make mistakes, when we don't have the knowledge there are other ways. That is partially what code review is about. > Never ever imagined that this would be replicated in

Re: [PATCH 17/18] net: iosm: readme file

2021-01-17 Thread Bjørn Mork
Sorry about being much too late into this discussion. I'm not having the bandwidth to read netdev anymore, and just stumbled across this now. Andrew Lunn writes: > So, this is what all the Ethernet nonsense is all about. You have a > session ID you need to somehow represent to user space. And y

Re: [PATCH 17/18] net: iosm: readme file

2021-01-15 Thread Johannes Berg
Hi Andrew, all, > > +For example, adding a link for a MBIM IP session with SessionId 5: > > + > > + ip link add link wwan0 name wwan0. type vlan id 5 > > So, this is what all the Ethernet nonsense is all about. You have a > session ID you need to somehow represent to user space. And you > decide

Re: [PATCH 17/18] net: iosm: readme file

2021-01-07 Thread Andrew Lunn
> diff --git a/drivers/net/wwan/iosm/README b/drivers/net/wwan/iosm/README Please convert this to rst, and put it somewhere under Documentation. > +Multiplexed IP sessions (IPS) > +- > +IOSM driver allows multiplexing of several IP sessions over the single > network >

[PATCH 17/18] net: iosm: readme file

2021-01-07 Thread M Chetan Kumar
Documents IOSM Driver interface usage. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/README | 126 +++ 1 file changed, 126 insertions(+) create mode 100644 drivers/net/wwan/iosm/README diff --git a/drivers/net/wwan/iosm/README b/drivers/net/wwa