Re: [PATCH 14/17] can: flexcan: remove ack_grp and ack_bit handling from driver

2020-10-14 Thread Marc Kleine-Budde
On 10/14/20 10:53 AM, Joakim Zhang wrote: >> Since commit: >> >> 048e3a34a2e7 can: flexcan: poll MCR_LPM_ACK instead of GPR ACK for >> stop mode acknowledgment >> >> the driver polls the IP core's internal bit MCR[LPM_ACK] as stop mode >> acknowledge and not the acknowledgment on chip level. >>

RE: [PATCH 14/17] can: flexcan: remove ack_grp and ack_bit handling from driver

2020-10-14 Thread Joakim Zhang
> -Original Message- > From: Marc Kleine-Budde > Sent: 2020年10月8日 5:32 > To: netdev@vger.kernel.org > Cc: da...@davemloft.net; linux-...@vger.kernel.org; > ker...@pengutronix.de; Marc Kleine-Budde ; Joakim > Zhang > Subject: [PATCH 14/17] can: flexcan: re

[PATCH 14/17] can: flexcan: remove ack_grp and ack_bit handling from driver

2020-10-07 Thread Marc Kleine-Budde
Since commit: 048e3a34a2e7 can: flexcan: poll MCR_LPM_ACK instead of GPR ACK for stop mode acknowledgment the driver polls the IP core's internal bit MCR[LPM_ACK] as stop mode acknowledge and not the acknowledgment on chip level. This means the 4th and 5th value of the property "fsl,stop-mo