Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX

2017-02-03 Thread Corentin Labbe
On Fri, Feb 03, 2017 at 10:15:30AM -0500, David Miller wrote: > From: Corentin Labbe > Date: Fri, 3 Feb 2017 14:41:45 +0100 > > > On Tue, Jan 31, 2017 at 11:12:25PM -0500, David Miller wrote: > >> From: Corentin Labbe > >> Date: Tue, 31 Jan 2017 10:11:48 +0100 > >> > >> > The stmmac driver run

Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX

2017-02-03 Thread David Miller
From: Corentin Labbe Date: Fri, 3 Feb 2017 14:41:45 +0100 > On Tue, Jan 31, 2017 at 11:12:25PM -0500, David Miller wrote: >> From: Corentin Labbe >> Date: Tue, 31 Jan 2017 10:11:48 +0100 >> >> > The stmmac driver run TX completion under NAPI but without checking >> > the work done by the TX com

Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX

2017-02-03 Thread Corentin Labbe
On Tue, Jan 31, 2017 at 11:12:25PM -0500, David Miller wrote: > From: Corentin Labbe > Date: Tue, 31 Jan 2017 10:11:48 +0100 > > > The stmmac driver run TX completion under NAPI but without checking > > the work done by the TX completion function. > > The current behavior is correct and complete

Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX

2017-01-31 Thread David Miller
From: Corentin Labbe Date: Tue, 31 Jan 2017 10:11:48 +0100 > The stmmac driver run TX completion under NAPI but without checking > the work done by the TX completion function. The current behavior is correct and completely intentional. A driver should _never_ account TX work to the NAPI poll bu

Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX

2017-01-31 Thread Corentin Labbe
On Tue, Jan 31, 2017 at 11:28:03AM +0100, Giuseppe CAVALLARO wrote: > On 1/31/2017 10:11 AM, Corentin Labbe wrote: > > The stmmac driver run TX completion under NAPI but without checking the > > work done by the TX completion function. > > > > This patch add work/budget to the TX completion functio

Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX

2017-01-31 Thread Giuseppe CAVALLARO
On 1/31/2017 10:11 AM, Corentin Labbe wrote: The stmmac driver run TX completion under NAPI but without checking the work done by the TX completion function. This patch add work/budget to the TX completion function. The visible effect is that it keep the driver longer under NAPI and boost perfo

[PATCH 13/17] net: stmmac: Implement NAPI for TX

2017-01-31 Thread Corentin Labbe
The stmmac driver run TX completion under NAPI but without checking the work done by the TX completion function. This patch add work/budget to the TX completion function. The visible effect is that it keep the driver longer under NAPI and boost performance. Under dwmac-sun8i the iperf goes from 1