Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

2018-05-20 Thread Marcelo Ricardo Leitner
On Mon, May 21, 2018 at 12:40:54AM +0300, Or Gerlitz wrote: > On Mon, May 21, 2018 at 12:33 AM, Marcelo Ricardo Leitner > wrote: > > On Mon, May 21, 2018 at 12:13:06AM +0300, Or Gerlitz wrote: > >> On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner > >> wrote: > >> > On Mon, May 14, 2018 at

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

2018-05-20 Thread Or Gerlitz
On Mon, May 21, 2018 at 12:33 AM, Marcelo Ricardo Leitner wrote: > On Mon, May 21, 2018 at 12:13:06AM +0300, Or Gerlitz wrote: >> On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner >> wrote: >> > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote: >> >> Substitute calls to action i

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

2018-05-20 Thread Marcelo Ricardo Leitner
On Mon, May 21, 2018 at 12:13:06AM +0300, Or Gerlitz wrote: > On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner > wrote: > > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote: > >> Substitute calls to action insert function with calls to action insert > >> unique function that war

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

2018-05-20 Thread Or Gerlitz
On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner wrote: > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote: >> Substitute calls to action insert function with calls to action insert >> unique function that warns if insertion overwrites index in idr. > > I know this patch may be

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

2018-05-19 Thread Marcelo Ricardo Leitner
On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote: > Substitute calls to action insert function with calls to action insert > unique function that warns if insertion overwrites index in idr. I know this patch may be gone on V2, but a general comment, please use the function names themsel

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

2018-05-16 Thread Vlad Buslov
On Wed 16 May 2018 at 09:50, Jiri Pirko wrote: > Mon, May 14, 2018 at 04:27:14PM CEST, vla...@mellanox.com wrote: >>Substitute calls to action insert function with calls to action insert >>unique function that warns if insertion overwrites index in idr. >> >>Signed-off-by: Vlad Buslov >>--- >> n

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

2018-05-16 Thread Jiri Pirko
Mon, May 14, 2018 at 04:27:14PM CEST, vla...@mellanox.com wrote: >Substitute calls to action insert function with calls to action insert >unique function that warns if insertion overwrites index in idr. > >Signed-off-by: Vlad Buslov >--- > net/sched/act_bpf.c| 2 +- > net/sched/act_connmark

[PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

2018-05-14 Thread Vlad Buslov
Substitute calls to action insert function with calls to action insert unique function that warns if insertion overwrites index in idr. Signed-off-by: Vlad Buslov --- net/sched/act_bpf.c| 2 +- net/sched/act_connmark.c | 2 +- net/sched/act_csum.c | 2 +- net/sched/act_gact.c