Re: [PATCH 12/21] [TCP]: Introduce per skb fack_counts to retransmit queue

2007-12-02 Thread Herbert Xu
On Sun, Dec 02, 2007 at 01:29:36PM +0200, Ilpo Järvinen wrote: > > Hmm didn't crash for me, probably a silent corruption instead :-(. It crashed during NIS start-up and I suppose I'm the only still running NIS :) > Maybe I could add catch for invalid skb dereferences (those list heads) to > TCP_S

Re: [PATCH 12/21] [TCP]: Introduce per skb fack_counts to retransmit queue

2007-12-02 Thread Ilpo Järvinen
On Sun, 2 Dec 2007, Herbert Xu wrote: > On Sun, Dec 02, 2007 at 12:48:07AM +0200, Ilpo Järvinen wrote: > > > > @@ -1220,6 +1221,11 @@ static inline struct sk_buff > > *tcp_write_queue_next(struct sock *sk, struct sk_bu > > return skb->next; > > } > > > > +static inline struct sk_buff *tcp_w

Re: [PATCH 12/21] [TCP]: Introduce per skb fack_counts to retransmit queue

2007-12-01 Thread Herbert Xu
On Sun, Dec 02, 2007 at 12:48:07AM +0200, Ilpo Järvinen wrote: > > @@ -1220,6 +1221,11 @@ static inline struct sk_buff > *tcp_write_queue_next(struct sock *sk, struct sk_bu > return skb->next; > } > > +static inline struct sk_buff *tcp_write_queue_prev(struct sock *sk, struct > sk_buff *s

[PATCH 12/21] [TCP]: Introduce per skb fack_counts to retransmit queue

2007-12-01 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> The fack count of any skb in the retransmit queue at any given point in time is: (skb->fack_count - head_skb->fack_count) And we'll use this in the SACK processing loops and possibly elsewhere too. Original idea came from David S. M