Re: [PATCH 12/14] Spidernet Avoid possible RX chain corruption

2006-12-14 Thread Michael Ellerman
On Thu, 2006-12-14 at 11:15 -0600, Linas Vepstas wrote: > On Thu, Dec 14, 2006 at 11:22:43AM +1100, Michael Ellerman wrote: > > > spider_net_refill_rx_chain(card); > > > - spider_net_enable_rxchtails(card); > > > spider_net_enable_rxdmac(card); > > > return 0; > > > > Didn't you just add tha

Re: [PATCH 12/14] Spidernet Avoid possible RX chain corruption

2006-12-14 Thread Christoph Hellwig
On Thu, Dec 14, 2006 at 11:15:11AM -0600, Linas Vepstas wrote: > On Thu, Dec 14, 2006 at 11:22:43AM +1100, Michael Ellerman wrote: > > > spider_net_refill_rx_chain(card); > > > - spider_net_enable_rxchtails(card); > > > spider_net_enable_rxdmac(card); > > > return 0; > > > > Didn't you just

Re: [PATCH 12/14] Spidernet Avoid possible RX chain corruption

2006-12-14 Thread Linas Vepstas
On Thu, Dec 14, 2006 at 11:22:43AM +1100, Michael Ellerman wrote: > > spider_net_refill_rx_chain(card); > > - spider_net_enable_rxchtails(card); > > spider_net_enable_rxdmac(card); > > return 0; > > Didn't you just add that line? Dagnabbit. The earlier pach was moving around existin

Re: [PATCH 12/14] Spidernet Avoid possible RX chain corruption

2006-12-13 Thread Michael Ellerman
On Wed, 2006-12-13 at 15:23 -0600, Linas Vepstas wrote: > Delete possible source of chain corruption; the hardware > already knows the location of the tail, and writing it > again is likely to mess it up. > > Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> > Cc: James K Lewis <[EMAIL PROTECTED]>

[PATCH 12/14] Spidernet Avoid possible RX chain corruption

2006-12-13 Thread Linas Vepstas
Delete possible source of chain corruption; the hardware already knows the location of the tail, and writing it again is likely to mess it up. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_ne