Re: [PATCH 11/18] d80211: clean up qdisc requeue

2006-08-22 Thread Johannes Berg
On Mon, 2006-08-21 at 21:31 +0200, Jiri Benc wrote: > to 802.11 qdisc dequeue function and then 0 will be a valid return code > from ieee80211_tx. Surely you mean non-zero here? :) How will that work in the case where NET_SCHED is enabled? johannes - To unsubscribe from this list: send the line

Re: [PATCH 11/18] d80211: clean up qdisc requeue

2006-08-21 Thread Jiri Benc
On Mon, 21 Aug 2006 09:41:18 +0200, Johannes Berg wrote: > There was a comment saying: > /* TODO: clean up the cases where master_hard_start_xmit > * returns non 0 - it shouldn't ever do that. Once done we > * can remove this function */ > > I noticed that master_hard_start_xmit never returns no

[PATCH 11/18] d80211: clean up qdisc requeue

2006-08-21 Thread Johannes Berg
There was a comment saying: /* TODO: clean up the cases where master_hard_start_xmit * returns non 0 - it shouldn't ever do that. Once done we * can remove this function */ I noticed that master_hard_start_xmit never returns nonzero by following the paths it calls. This patch hence removes the f