Re: [PATCH 10/18] maccess: unify the probe kernel arch hooks

2020-05-18 Thread Christoph Hellwig
On Thu, May 14, 2020 at 10:13:18AM +0900, Masami Hiramatsu wrote: > > + bool strict) > > { > > long ret; > > mm_segment_t old_fs = get_fs(); > > > > + if (!probe_kernel_read_allowed(dst, src, size, strict)) > > + return -EFAULT; > > Could you make this return -ERAN

Re: [PATCH 10/18] maccess: unify the probe kernel arch hooks

2020-05-13 Thread Masami Hiramatsu
Hi Christoph, On Wed, 13 May 2020 18:00:30 +0200 Christoph Hellwig wrote: > @@ -36,14 +50,20 @@ long __weak probe_kernel_read(void *dst, const void *src, > size_t size) > * probe_kernel_read() suitable for use within regions where the caller > * already holds mmap_sem, or other locks which

[PATCH 10/18] maccess: unify the probe kernel arch hooks

2020-05-13 Thread Christoph Hellwig
Currently architectures have to override every routine that probes kernel memory, which includes a pure read and strcpy, both in strict and not strict variants. Just provide a single arch hooks instead to make sure all architectures cover all the cases. Signed-off-by: Christoph Hellwig --- arch